From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: [bug] read-passwd of CVS Emacs
Date: Wed, 24 May 2006 10:08:46 -0600 [thread overview]
Message-ID: <e520fo$ama$1@sea.gmane.org> (raw)
In-Reply-To: <20060524.123750.178780620.kazu@iij.ad.jp>
Kazu Yamamoto (山本和彦) wrote:
> If the CONFIRM argument is specified to read-passwd of CVS Emacs,
> it causes an error after a user type a first password.
>
> (read-passwd "password: " t)
The error is "Attempt to modify read-only object" and is somehow caused
by a string indexing bug. Here's a patch:
2006-05-24 Kevin Rodgers <ihs_4664@yahoo.com>
* subr.el (read-passwd): Fix END argument to add-text-properties.
*** lisp/subr.el~ 2006-04-22 06:42:24.750000000 -0600
--- lisp/subr.el 2006-05-24 09:56:54.555250000 -0600
***************
*** 1542,1548 ****
(echo-keystrokes 0)
(cursor-in-echo-area t)
(message-log-max nil))
! (add-text-properties 0 (length prompt)
minibuffer-prompt-properties prompt)
(while (progn (message "%s%s"
prompt
--- 1542,1548 ----
(echo-keystrokes 0)
(cursor-in-echo-area t)
(message-log-max nil))
! (add-text-properties 0 (1- (length prompt))
minibuffer-prompt-properties prompt)
(while (progn (message "%s%s"
prompt
Thanks,
--
Kevin
next prev parent reply other threads:[~2006-05-24 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 3:37 [bug] read-passwd of CVS Emacs Kazu Yamamoto
2006-05-24 16:08 ` Kevin Rodgers [this message]
2006-05-24 16:35 ` David Kastrup
2006-05-24 18:29 ` Kevin Rodgers
2006-05-24 21:09 ` Johan Bockgård
2006-05-24 22:08 ` David Kastrup
2006-05-25 0:37 ` Richard Stallman
2006-05-25 16:31 ` Kevin Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e520fo$ama$1@sea.gmane.org' \
--to=ihs_4664@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).