From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Rommel Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: bufferlo Date: Sat, 04 Nov 2023 23:13:29 +0100 Message-ID: References: <8c3006d57a5c18905267adccfb04caf5ee1721ab.camel@florommel.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24644"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.50.1 To: Stefan Kangas , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 04 23:14:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzOuY-0006GQ-G0 for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Nov 2023 23:14:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzOtj-0000DR-6C; Sat, 04 Nov 2023 18:13:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzOth-0000Ch-KU for emacs-devel@gnu.org; Sat, 04 Nov 2023 18:13:41 -0400 Original-Received: from read.uberspace.de ([185.26.156.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzOtf-0003lV-LK for emacs-devel@gnu.org; Sat, 04 Nov 2023 18:13:41 -0400 Original-Received: (qmail 11884 invoked by uid 990); 4 Nov 2023 22:13:30 -0000 Authentication-Results: read.uberspace.de; auth=pass (plain) In-Reply-To: Autocrypt: addr=mail@florommel.de; prefer-encrypt=mutual; keydata=mQINBGDTtoIBEACZ2Uo6jLSH6I/oJs2G/eTaw0I+EqAIpyf5zdn6GlMb68hsrseM+xLdUB70W+WgIEaZTM0eYSJfoE8MAqUbiBjR8ZArXHM8x41/giVzaH7Mj3hayAoZaB/yphd4bWsRzbiudehQtc8ipk+tzsfkXzX3y5MiwHR4gzklowp56Usv6JfCbc053KNdkMoXPffYYFAJge1WQZH6eyD04QndPewEOr/bZ75Q9Xykfyl5271OQZk9j9q/rnJfW9OrCI9SzduPkteLFKZ7QCx2i2V8guErfeZ5XoHmh2oiTiW52W/m8GWr6tAMeH8jCCc+llGktMvACyjvWUPhCDqsIIWRusD6PB0gxA9Bg1621Ep5mTuXPiL3USqn90p8Ng8DdzqcpF1aiuEo/VHjeRU3N7kHxpN5P43+lmxwVh09I3tAhbvm5YySL1/Mh2wdBX/CQ7FMXRctpslpWmIA8YlvtS6nj9sHDWOIGyLlYYkroeWXMDMB5vEGu/qStx9EH2rX+N/vvm6B5zjHnNCXCGRhk0viJkFkiRGWaYLwZmuJV1uGXgDcoybthNS8c9fyvpegvihwuqH2r0CN14iW/kqmLN8f/KZUKROvDaHAqLRGOsvAxVlgGXw7++YVsbzfd97ZDvb0aqRkmpSi+pzV7cV56BIcAbt5TX4f/2Z0SlhZlRIEP+3TswARAQABtCJGbG9yaWFuIFJvbW1lbCA8bWFpbEBmbG9yb21tZWwuZGU+iQJOBBMBCAA4FiEEQ4pDiQMbD3BHr4SfIFFAnAz WtlgFAmDTtoICGwMFCwkIBwIGFQoJCAsCBBYCAwE X-Rspamd-Bar: / X-Rspamd-Report: BAYES_HAM(-0.106588) MIME_GOOD(-0.1) X-Rspamd-Score: -0.206588 Original-Received: from unknown (HELO unkown) (::1) by read.uberspace.de (Haraka/3.0.1) with ESMTPSA; Sat, 04 Nov 2023 23:13:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=florommel.de; s=uberspace; h=from; bh=qeDccGvztjH7tTKriJSwDFDAje00pQnJMj1cb12h62U=; b=EZ6HlmXqVthU4OTb0XTAbaRA5hCsSE7X/bO133RsWEDiSBy1msiu7Yq3olG6Rh3mP3F50zHF/p W+w+g7oIZUimfNoo2jhDDyim9AgFvX7j6euFddBenAq/v+qPmLaG104TEvAevDohpgiiL3RxMQLc HGpwoZOKuYg63MThGeot+L0oxWkwsObT5DGof5TQq/GjJG57haP9x8Yt7Ixibvj6DsWyT2RkZsu9 YcNbeceVM9jkXyfuo+6oq7UPEe5z8IZNMKefijTMfdM9M0w/1EW9TMpzSHE/YyKOjRRrZw9hkGt5 Wf375faUY4su4pnTrofiEblOoQbDQx4tX5ryI5WugZ0YrF/PHeJ8XXsKBatG5/C/D94gGBFu297k ZIgP7qgRtemUsAhT8PZkvEL7HCfyUFkdn5y7dcJAOJ8+mWXGzMrsrnQZtW3YE1WWioFif+jku9nc v4dfzN+Xzx/+uDTupFNNEwSRdh1NxsKAwMRtqaX70ViclO04EGcikc70fZu1WOzLi61Zp1S3cfIC qoB7xdOtZ6z2C8yyonKKg33UsGDuULSiGnXbBgzgV+PIQvsyDF49Xk1wbwc/uJY73G6sgu1H50bf GQpof528HvkSpOVNyDltQYI68Dj8RP6TJpQ0SthAPuoqT+co4S0IzR9B5g8MJTduappHeWkE1Qfn 0= Received-SPF: pass client-ip=185.26.156.133; envelope-from=mail@florommel.de; helo=read.uberspace.de X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312225 Archived-At: On Sat, 2023-10-28 at 08:21 -0700, Stefan Kangas wrote: > Thanks, do you mean to add it to GNU ELPA? If so, I see no reason why > we can't add it. Please find some comments on your code below. Yes, I would like to have it added to GNU ELPA. > 1. Here are some warnings from `package-lint': >=20 > 6 issues found: >=20 > 146:22: error: You should depend on (emacs "28.1") if you need `clone-fra= me'. > 147:22: error: You should depend on (emacs "29.1") if you need `undelete-= frame'. > 166:21: error: You should depend on (emacs "28.1") if you need `clone-fra= me'. > 167:21: error: You should depend on (emacs "29.1") if you need `undelete-= frame'. The package works with 27.1. The advices for `clone-frame' and `undelete-frame' are just supplementary and not necessary for the functioning of bufferlo. `add-advice' does not fail for undefined functions but seems to define nonexistent functions as empty functions. To avoid this, I now check `emacs-major-version' before adding the advice for `clone-frame' and `undelete-frame'. Of course, this does not fix the warnings. > 517:1: warning: `with-eval-after-load' is for use in configurations, > and should rarely be used in packages. > 523:1: warning: `with-eval-after-load' is for use in configurations, > and should rarely be used in packages. >=20 > 2. Here are some byte-compiler warnings: >=20 > Compiling file /Users/skangas/wip/bufferlo/bufferlo.el at Sat Oct 28 > 17:12:56 2023 > bufferlo.el:518:26: Warning: reference to free variable > =E2=80=98ibuffer-filtering-alist=E2=80=99 > bufferlo.el:517:24: Warning: assignment to free variable > =E2=80=98ibuffer-filtering-alist=E2=80=99 > bufferlo.el:526:17: Warning: reference to free variable =E2=80=98ibuffer-= -filter-map=E2=80=99 >=20 > In end of data: > bufferlo.el:527:19: Warning: the function > =E2=80=98ibuffer-filter-by-bufferlo-local-buffers=E2=80=99 is not kno= wn to be defined. > bufferlo.el: Warning: the function =E2=80=98ibuffer-pop-filter=E2=80=99 i= s not known to be > defined. > bufferlo.el: Warning: the function =E2=80=98ibuffer-update=E2=80=99 is no= t known to be > defined. > bufferlo.el: Warning: the function =E2=80=98ibuffer-push-filter=E2=80=99 = is not known to be > defined. >=20 Bufferlo has ibuffer support but does not need ibuffer to be useful. Therefore, I use `with-eval-after-load' blocks for the ibuffer-related code. The free-variable warnings arise from the usage of ibuffer variables in these blocks. As an alternative, I could require ibuffer, which, however, would load ibuffer for all users of bufferlo, even if they don't use it. What is the preferred solution? > 3. You might want to consider running `M-x checkdoc' as well. I resolved all the remaining checkdoc warnings. > 4. See the below diff with some stylistic improvements that I found > while skimming the code: Thanks, I applied your improvements. For now, minus 'Package-Requires: ((emacs "29.1"))' Regards,=20 Flo