From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Problems setting byte-compile-warnings to t Date: Sun, 28 Oct 2007 19:58:54 -0400 Message-ID: References: <9p8x5qiwik.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193615950 5327 80.91.229.12 (28 Oct 2007 23:59:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2007 23:59:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 00:59:12 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImI2A-0002h2-2i for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2007 00:59:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImI20-0000bu-WE for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 19:59:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImI1x-0000aI-Th for emacs-devel@gnu.org; Sun, 28 Oct 2007 19:58:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImI1w-0000XW-9D for emacs-devel@gnu.org; Sun, 28 Oct 2007 19:58:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImI1w-0000X9-3K for emacs-devel@gnu.org; Sun, 28 Oct 2007 19:58:56 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImI1v-0004IG-Uj for emacs-devel@gnu.org; Sun, 28 Oct 2007 19:58:56 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1ImI1u-0006RS-9E; Sun, 28 Oct 2007 19:58:54 -0400 X-Spook: Bletchley Park Baranyi CDMA Janet Reno SRI Mantis Firefly X-Ran: XUB+JjrnD)9QvmX)`Uqgz+OL{^7q;GJ&..<=I&Bj'UYL(hC[JQ^|7~Tw6xtd:M<-qLLXM= X-Hue: white X-Attribution: GM In-Reply-To: (Richard Stallman's message of "Sun, 28 Oct 2007 09:51:09 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82001 Archived-At: Richard Stallman wrote: > So the simplest fix would seem to adjust the buffer-local value in > inbuffer in the same way that byte-compile-close-variables does. > > I see a problem with that: such a change would persist after the end > of the compilation. Yes, but in an internal buffer used only by byte-compilation, so I don't see the problem. Anyway... > Here's another idea: add a function byte-compile-memq which always > returns t if the second arg is t, and use that instead of memq to test > membership in byte-compile-warnings. That avoids the need to alter > data provided by the user. I installed a changes along these lines: byte-compile-warning-enabled-p. I also took the opportunity to allow byte-compile-warnings to specify a list of warnings to _disable_. Useful for compiling emacs-lisp/cl-*, IMO.