unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Problems setting byte-compile-warnings to t
Date: Sun, 28 Oct 2007 19:58:54 -0400	[thread overview]
Message-ID: <e4sl3usse9.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <E1Im8Xl-0000xi-IG@fencepost.gnu.org> (Richard Stallman's message of "Sun, 28 Oct 2007 09:51:09 -0400")

Richard Stallman wrote:

>     So the simplest fix would seem to adjust the buffer-local value in
>     inbuffer in the same way that byte-compile-close-variables does.
>
> I see a problem with that: such a change would persist after the end
> of the compilation.

Yes, but in an internal buffer used only by byte-compilation, so I
don't see the problem. Anyway...

> Here's another idea: add a function byte-compile-memq which always
> returns t if the second arg is t, and use that instead of memq to test
> membership in byte-compile-warnings.  That avoids the need to alter
> data provided by the user.

I installed a changes along these lines: byte-compile-warning-enabled-p.

I also took the opportunity to allow byte-compile-warnings to specify
a list of warnings to _disable_. Useful for compiling emacs-lisp/cl-*, IMO.

  reply	other threads:[~2007-10-28 23:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 22:42 Problems setting byte-compile-warnings to t Glenn Morris
2007-10-25 23:50 ` Glenn Morris
2007-10-27  2:28   ` Richard Stallman
2007-10-27  3:36     ` Glenn Morris
2007-10-28 13:51       ` Richard Stallman
2007-10-28 23:58         ` Glenn Morris [this message]
2007-10-29  9:22           ` Richard Stallman
2007-10-29 18:39           ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4sl3usse9.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).