From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Fri, 30 Apr 2021 20:30:48 +0200 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <24f3b5e7-3e5e-d00f-3fc4-9d093ca1dc10@daniel-mendler.de> <87fsz7wvu5.fsf@mail.linkov.net> <46a170c1-7d81-8ed5-e61a-d8193b640d16@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21405"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 20:33:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcXxB-0005TA-6w for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 20:33:29 +0200 Original-Received: from localhost ([::1]:38166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcXxA-0002wd-3A for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 14:33:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXuh-0002BR-UH for emacs-devel@gnu.org; Fri, 30 Apr 2021 14:30:55 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:55473 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcXuf-0005Fe-3Z for emacs-devel@gnu.org; Fri, 30 Apr 2021 14:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AAT45o5O0iYmbthEJXJglzFQUYR9ZwiiNa4JKoty4+0=; b=x88cPMe4kXy2HG5YJZTIbQyzIb wZHbUR2grWXn/Qvx+MreDw8HsI+u91KKbx8PlMjmmxzs+am2Ha7+AXsw7U3WmiarMf8ksun0i4PSD cLxu974iWlJOQEmkK4N5UYHPm/dgMpFXkHbHBHhLK/NRGhK9EEDKae2fiC2cgWLQZhIY=; In-Reply-To: <46a170c1-7d81-8ed5-e61a-d8193b640d16@daniel-mendler.de> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268684 Archived-At: On 4/30/21 8:11 PM, Daniel Mendler wrote: > On 4/30/21 7:01 PM, Juri Linkov wrote: >> Thanks, I tested the vertical and horizontal format, >> and the horizontal format is displayed nicely, but I expected >> that in the vertical format completions inside every group >> to be arranged the same way as in horizontal format, e.g. >> everything is fine in the horizontal format: > > Yes, this is intentional. I assume that one would want to have headers > per column as in a two column paper layout for example. We can also use > the different layout if that is preferred. I believe the arrangement I am using in the current patch is is the more natural one. For the horizontal layout we insert the candidates like this: >>-----------\ | /------------/ | \------------\ | /------------/ | \----------->> For the vertical layout we insert the candidates like this: v /--\ /--\ v | | | | | | | | | | | | | | | | | | v \--/ \--/ v What you proposed for the vertical layout would look like this v /--\ /--\ v | | | | | | | | v \--/ \--/ v ============= v /--\ /--\ v | | | | | | | | v \--/ \--/ v ============= v /--\ /--\ v | | | | | | | | v \--/ \--/ v This seems to me like a mix of vertical and horizontal layout. Daniel