From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: Should yaml-ts-mode inherit from prog-mode? Date: Tue, 7 Mar 2023 12:27:50 +0100 Message-ID: References: <87356ooaae.fsf@tcd.ie> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------G7dS5Xlg5XUs9K1ZJcqo06Ue" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= , Romanos Skiadas , emacs-devel@gnu.org To: Basil Contovounesios , Matthias Meulien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 07 12:28:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVUm-000AIw-NK for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Mar 2023 12:28:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZVUD-0006iM-DF; Tue, 07 Mar 2023 06:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZVU7-0006iB-68 for emacs-devel@gnu.org; Tue, 07 Mar 2023 06:27:59 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZVU5-0005UX-6U for emacs-devel@gnu.org; Tue, 07 Mar 2023 06:27:58 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 131C15C011C; Tue, 7 Mar 2023 06:27:53 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 07 Mar 2023 06:27:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:sender:subject:subject:to:to; s= fm3; t=1678188473; x=1678274873; bh=DA1AF/yp9Q9VrqY0t8n+QNHol4fj Yg2+F84uxA8bvj0=; b=X3TtUXmilLFTnZLQ2Fp+2CeCg+lBObDdneZOcalih1/z PTomsfwGsIaWOvGv6tjRdsEu3Dtvdlqzg10U1J5wwggpfhjy+xwIefuIUjysPQyO PtP+bJS1IMIYv5m/p6GwZdgsnYyYfCX1K/7v9xVx07yShP+R4JkQv9ajlmab8+XW uagAhimye29GPi1qoJFFG0rLg8mm3TNzG/xjKtNFxcg1Llet6+vTf238XuNgChE1 G/NqIYlhkzn8K5+UH5OlCDyWZbTDXl6Kqa9W3tp8pHRPW7M+3DPpNc+LLZzkRvwN +Q18jaD38PcbwDiWklXug0Ch3V1dn1+O/MhDnseCMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1678188473; x=1678274873; bh=D A1AF/yp9Q9VrqY0t8n+QNHol4fjYg2+F84uxA8bvj0=; b=F72H5ge+Djtg7pTQd SFQPOnjsOrd8fkcbr5cAmbfyFnsNFiBP7wkqrVgE2FMllcfH71J8u7d/uLyeSvrW ub6XjnikpaJlyd+kyt/Yo4UEaNxmGrabYc6YM9eLkaSF++Nj+z0WfElWiWBCYv93 mDgBe65LXnR1RQXV6LZ79YkvL4BWq2pbRdwkr1hAwPgR6UGCwWeO/JlSR1cO5uR4 MGUv2i8844YvNB8Jwmsi4ljsTObFBTS3ninNOT6cJd7kNjsqZ4y7XmHSXpdde+/S UUgSXDsrwBPFgzo5PhME9Zueta7n7qDwLf6/KQooxvYUhCTozCAp+jERUFKRTfaQ Qdbdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddutddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeujeejteehhfefgffftefghefg geeigeegtddvjeetjeejgedvueejhffgueefgeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Mar 2023 06:27:52 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <87356ooaae.fsf@tcd.ie> Received-SPF: pass client-ip=66.111.4.28; envelope-from=jostein@secure.kjonigsen.net; helo=out4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304075 Archived-At: This is a multi-part message in MIME format. --------------G7dS5Xlg5XUs9K1ZJcqo06Ue Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Matthias Meulien [2023-03-01 08:46 +0100] wrote: > Emacs 29 introduces a toml-ts-mode based on > text-mode. I'm not sure how intentional/desirable that is, so at risk > of blowing this thread out of proportion I'm copying in Jostein as well. > > Thanks, > Hey. Author of toml-ts-mode here. I originally implemented it as a prog-mode derived mode (because for the same reasons as reiterated above, that made sense to me). I was however asked by the more senior Emacs maintainers to make it text-mode instead. So while it was not my decision, I'd just like to point out that there /was/ a decision-making process involved when text-mode was decided. If someone were to change this back to prog-mode before we ship Emacs 29, I would have no objections to that, but I have no authority to mandate such a change either :) -- Jostein --------------G7dS5Xlg5XUs9K1ZJcqo06Ue Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Matthias Meulien [2023-03-01 08:46 +0100] wrote: 

      Emacs 29 introduces a toml-ts-mode based on
      
      
text-mode.  I'm not sure how intentional/desirable that is, so at risk
of blowing this thread out of proportion I'm copying in Jostein as well.

Thanks,



    

    
Hey.

    
Author of toml-ts-mode here.

    
I originally implemented it as a prog-mode
        derived mode (because for the same reasons as reiterated above,
        that made sense to me).

    
I was however asked by the more senior
        Emacs maintainers to make it text-mode instead.

    
So while it was not my decision, I'd just
        like to point out that there was a decision-making
        process involved when text-mode was decided.

    
If someone were to change this back to
        prog-mode before we ship Emacs 29, I would have no objections to
        that, but I have no authority to mandate such a change either :)

      

    
--

        Jostein

      

  


--------------G7dS5Xlg5XUs9K1ZJcqo06Ue--