From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jm@pub.pink, emacs-devel@gnu.org
Subject: Re: master 5f9b5803bea: Fix zooming images in SHR
Date: Tue, 25 Jun 2024 22:09:20 -0700 [thread overview]
Message-ID: <e42bab4f-5699-4a73-68dd-7f09f2fecc48@gmail.com> (raw)
In-Reply-To: <86y16ublts.fsf@gnu.org>
On 6/24/2024 4:51 AM, Eli Zaretskii wrote:
> I don't see any additional info when I delete that line, but maybe I'm
> missing something.
Hmm. What do you see if you try this patch? (Warning, it may print quite
a bit since it'll dump the full buffer contents including properties.)
----------------------------------------
diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el
index 4864fc488e2..c4c861bf958 100644
--- a/test/lisp/net/shr-tests.el
+++ b/test/lisp/net/shr-tests.el
@@ -138,7 +138,8 @@ shr-test/zoom-image
(skip-unless (bound-and-true-p image-types))
(let ((image (expand-file-name "data/image/blank-100x200.png"
(getenv "EMACS_TEST_DIRECTORY"))))
- (dolist (alt '(nil "" "nothing to see here"))
+ (dolist (alt '(nil ;; "" "nothing to see here"
+ ))
(with-temp-buffer
(ert-info ((format "image with alt=%S" alt))
(let ((attrs (if alt (format " alt=\"%s\"" alt) "")))
@@ -156,16 +157,21 @@ shr-test/zoom-image
(shr-width 80)
(shr-use-fonts nil)
(shr-image-animate nil)
- (inhibit-message t)
+ ;; (inhibit-message t)
(dom (libxml-parse-html-region (point-min)
(point-max))))
;; Render the document.
(erase-buffer)
(shr-insert-document dom)
- (shr-test-wait-for (lambda () (= put-image-calls 1)))
+ (message "Initial buffer contents:\n%S\n\n" (buffer-string))
+ (shr-test-wait-for (lambda () (= put-image-calls 1))
+ "Timed out waiting for initial load")
+ (message "Fully-loaded buffer contents:\n%S\n\n"
(buffer-string))
;; Now zoom the image.
(goto-char (point-min))
(shr-zoom-image)
- (shr-test-wait-for (lambda () (= put-image-calls 2)))
+ (shr-test-wait-for (lambda () (= put-image-calls 2))
+ "Timed out waiting to zoom image")
+ (message "Final buffer contents:\n%S\n\n" (buffer-string))
;; Check that we got a sliced image.
(let ((slice-count 0))
(goto-char (point-min))
next prev parent reply other threads:[~2024-06-26 5:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171912324641.7384.11296304660836747605@vcs2.savannah.gnu.org>
[not found] ` <20240623061407.0C6DDC1FB5C@vcs2.savannah.gnu.org>
2024-06-23 14:36 ` master 5f9b5803bea: Fix zooming images in SHR john muhl
2024-06-23 18:42 ` Jim Porter
2024-06-23 19:23 ` Eli Zaretskii
2024-06-23 22:13 ` Jim Porter
2024-06-24 11:51 ` Eli Zaretskii
2024-06-26 5:09 ` Jim Porter [this message]
2024-06-26 13:49 ` Eli Zaretskii
2024-06-26 15:58 ` Jim Porter
2024-06-26 16:04 ` Eli Zaretskii
2024-06-28 3:51 ` Jim Porter
2024-06-28 12:04 ` Eli Zaretskii
2024-06-28 17:46 ` Jim Porter
2024-06-29 11:09 ` Eli Zaretskii
2024-06-29 22:00 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e42bab4f-5699-4a73-68dd-7f09f2fecc48@gmail.com \
--to=jporterbugs@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).