unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Emacs (HEAD) crash on M$ (XP) built with MinGW
@ 2008-10-20 12:38 dhruva
  2008-10-20 14:41 ` Eli Zaretskii
  0 siblings, 1 reply; 21+ messages in thread
From: dhruva @ 2008-10-20 12:38 UTC (permalink / raw)
  To: Emacs Devel

Hi,
 I am still seeing the elusive and infrequent crash. I open a 'C'
file, maximize the frame and use the page down to scroll down or down
arrow. I keep hitting this crash off and now. The tried getting 'xbt'
and could not. I will keep trying again and get some extra
information.

(gdb) bt
#0  0x0103ca47 in next_element_from_string (it=0x82e1ac) at xdisp.c:6263
#1  0x0103b03e in get_next_display_element (it=0x82e1ac) at xdisp.c:5655
#2  0x0103591d in init_from_display_pos (it=0x82e1ac, w=0x38f0e00,
pos=0x3af23e0) at xdisp.c:3035
#3  0x01035958 in init_to_row_start (it=0x82e1ac, w=0x38f0e00,
row=0x3af23a0) at xdisp.c:3054
#4  0x0104e230 in try_window_reusing_current_matrix (w=0x38f0e00) at
xdisp.c:14396
#5  0x0104baa4 in redisplay_window (window=59706884,
just_this_one_p=1) at xdisp.c:13784
#6  0x01047d6f in redisplay_window_1 (window=59706884) at xdisp.c:12264
#7  0x01021b55 in internal_condition_case_1 (bfun=0x1047d42
<redisplay_window_1>, arg=59706884, handlers=44971509, hfun=0x1047cea
<redisplay_window_error>) at eval.c:1559
#8  0x01047087 in redisplay_internal (preserve_echo_area=0) at xdisp.c:11882
#9  0x010453c1 in redisplay () at xdisp.c:11016
#10 0x01008d95 in read_char (commandflag=1, nmaps=6, maps=0x82f890,
prev_event=44988417, used_mouse_menu=0x82fa44, end_time=0x0) at
keyboard.c:2649
#11 0x01012af4 in read_key_sequence (keybuf=0x82fc58, bufsize=30,
prompt=44988417, dont_downcase_last=0, can_return_switch_frame=1,
fix_current_buffer=1) at keyboard.c:9343
#12 0x010064ba in command_loop_1 () at keyboard.c:1621
#13 0x01021a56 in internal_condition_case (bfun=0x100618f
<command_loop_1>, handlers=45052169, hfun=0x1005b8c <cmd_error>) at
eval.c:1511
#14 0x01005ed8 in command_loop_2 () at keyboard.c:1338
#15 0x01021566 in internal_catch (tag=45048241, func=0x1005eb8
<command_loop_2>, arg=44988417) at eval.c:1247
#16 0x01005e8f in command_loop () at keyboard.c:1317
#17 0x01005792 in recursive_edit_1 () at keyboard.c:942
#18 0x01005900 in Frecursive_edit () at keyboard.c:1004
#19 0x0100281c in main (argc=1, argv=0xa42f30) at emacs.c:1728
(gdb)

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-20 12:38 Emacs (HEAD) crash on M$ (XP) built with MinGW dhruva
@ 2008-10-20 14:41 ` Eli Zaretskii
  2008-10-21  3:42   ` dhruva
  0 siblings, 1 reply; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-20 14:41 UTC (permalink / raw)
  To: dhruva; +Cc: emacs-devel

> Date: Mon, 20 Oct 2008 18:08:15 +0530
> From: dhruva <dhruvakm@gmail.com>
> 
>  I am still seeing the elusive and infrequent crash. I open a 'C'
> file, maximize the frame and use the page down to scroll down or down
> arrow. I keep hitting this crash off and now. The tried getting 'xbt'
> and could not.

xbacktrace will not give you any useful information when the crash is
inside redisplay, at least not normally, because redisplay is not
normally triggered by Lisp code.  Redisplay is what Emacs normally
does when it is idle (on the C level).

> (gdb) bt
> #0  0x0103ca47 in next_element_from_string (it=0x82e1ac) at xdisp.c:6263
> #1  0x0103b03e in get_next_display_element (it=0x82e1ac) at xdisp.c:5655
> #2  0x0103591d in init_from_display_pos (it=0x82e1ac, w=0x38f0e00,
> pos=0x3af23e0) at xdisp.c:3035

Is this optimized build or unoptimized one?  If the former, please try
reproducing the crashes with unoptimized builds.  If this is already
unoptimized, please see what part(s) of the `it' structure caused the
crash, and show here their value(s).

If your xdisp.c is current, and assuming that this is an unoptimized
build (and so the backtrace is trustworthy), the problem seems to be
with trying to display something based on some string, which is stored
at it->string.  Could you please see what string is that, and what is
its contents?  That might give us a clue about whodunit.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-20 14:41 ` Eli Zaretskii
@ 2008-10-21  3:42   ` dhruva
  2008-10-21  5:40     ` dhruva
  0 siblings, 1 reply; 21+ messages in thread
From: dhruva @ 2008-10-21  3:42 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Hello,

On Mon, Oct 20, 2008 at 8:11 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 20 Oct 2008 18:08:15 +0530
>> From: dhruva <dhruvakm@gmail.com>
>>
>>  I am still seeing the elusive and infrequent crash. I open a 'C'
>> file, maximize the frame and use the page down to scroll down or down
>> arrow. I keep hitting this crash off and now. The tried getting 'xbt'
>> and could not.
>
> xbacktrace will not give you any useful information when the crash is
> inside redisplay, at least not normally, because redisplay is not
> normally triggered by Lisp code.  Redisplay is what Emacs normally
> does when it is idle (on the C level).
>
>> (gdb) bt
>> #0  0x0103ca47 in next_element_from_string (it=0x82e1ac) at xdisp.c:6263
>> #1  0x0103b03e in get_next_display_element (it=0x82e1ac) at xdisp.c:5655
>> #2  0x0103591d in init_from_display_pos (it=0x82e1ac, w=0x38f0e00,
>> pos=0x3af23e0) at xdisp.c:3035
>
> Is this optimized build or unoptimized one?  If the former, please try

built with '--no-opt' (disabled optimization)

> If your xdisp.c is current, and assuming that this is an unoptimized
> build (and so the backtrace is trustworthy), the problem seems to be
> with trying to display something based on some string, which is stored
> at it->string.  Could you please see what string is that, and what is
> its contents?  That might give us a clue about whodunit.

Sure, I will look at those more closely. It happens when I open a 'C' file with
global-font-lock enabled. I will try to get stack dumps with all extra
information.

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  3:42   ` dhruva
@ 2008-10-21  5:40     ` dhruva
  2008-10-21  5:58       ` dhruva
                         ` (2 more replies)
  0 siblings, 3 replies; 21+ messages in thread
From: dhruva @ 2008-10-21  5:40 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Hi,
 I am now able to reproduce (on M$).
1. run emacs with default frame
2. Open a file with font-lock (some mid sized 'C' file)
3. Maximize the frame
4. scroll down using arrow with the cursor in the 1st column
5. On reaching the last line in the visible frame (not file), the crash happens

The following patch fixes this crash (but I do not know why it is NULL):

diff --git a/src/xdisp.c b/src/xdisp.c
index 47ba85f..f9d34c8 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -6240,6 +6240,12 @@ next_element_from_string (it)
 {
   struct text_pos position;

+  /* if string is NULL, nothing much we can do */
+  if (NULL == it->string)
+    {
+      return 0;
+    }
+
   xassert (STRINGP (it->string));
   xassert (IT_STRING_CHARPOS (*it) >= 0);
   position = it->current.string_pos;

-dhruva

On Tue, Oct 21, 2008 at 9:12 AM, dhruva <dhruvakm@gmail.com> wrote:
> Hello,
>
> On Mon, Oct 20, 2008 at 8:11 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> Date: Mon, 20 Oct 2008 18:08:15 +0530
>>> From: dhruva <dhruvakm@gmail.com>
>>>
>>>  I am still seeing the elusive and infrequent crash. I open a 'C'
>>> file, maximize the frame and use the page down to scroll down or down
>>> arrow. I keep hitting this crash off and now. The tried getting 'xbt'
>>> and could not.
>>
>> xbacktrace will not give you any useful information when the crash is
>> inside redisplay, at least not normally, because redisplay is not
>> normally triggered by Lisp code.  Redisplay is what Emacs normally
>> does when it is idle (on the C level).
>>
>>> (gdb) bt
>>> #0  0x0103ca47 in next_element_from_string (it=0x82e1ac) at xdisp.c:6263
>>> #1  0x0103b03e in get_next_display_element (it=0x82e1ac) at xdisp.c:5655
>>> #2  0x0103591d in init_from_display_pos (it=0x82e1ac, w=0x38f0e00,
>>> pos=0x3af23e0) at xdisp.c:3035
>>
>> Is this optimized build or unoptimized one?  If the former, please try
>
> built with '--no-opt' (disabled optimization)
>
>> If your xdisp.c is current, and assuming that this is an unoptimized
>> build (and so the backtrace is trustworthy), the problem seems to be
>> with trying to display something based on some string, which is stored
>> at it->string.  Could you please see what string is that, and what is
>> its contents?  That might give us a clue about whodunit.
>
> Sure, I will look at those more closely. It happens when I open a 'C' file with
> global-font-lock enabled. I will try to get stack dumps with all extra
> information.



-- 
Contents reflect my personal views only!




^ permalink raw reply related	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  5:40     ` dhruva
@ 2008-10-21  5:58       ` dhruva
  2008-10-21  6:38       ` Eli Zaretskii
  2008-10-21  6:41       ` Eli Zaretskii
  2 siblings, 0 replies; 21+ messages in thread
From: dhruva @ 2008-10-21  5:58 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Hi,
This seems better, the compiler does not warn. Should we add some
logging to help debugging here. Since I have absolutely no idea about
display engine, I am not sure what information could help developers
debug this issue. My changes silently swallow the problem through
defensive programming without finding the root cause. This patch
positively fixes the crash though!

diff --git a/src/xdisp.c b/src/xdisp.c
index 47ba85f..2b1b306 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -6240,6 +6240,12 @@ next_element_from_string (it)
 {
   struct text_pos position;

+  /* if string is 0/NULL, nothing much we can do */
+  if (!(it->string))
+    {
+      return 0;
+    }
+
   xassert (STRINGP (it->string));
   xassert (IT_STRING_CHARPOS (*it) >= 0);
   position = it->current.string_pos;

-dhruva

On Tue, Oct 21, 2008 at 11:10 AM, dhruva <dhruvakm@gmail.com> wrote:
> Hi,
>  I am now able to reproduce (on M$).
> 1. run emacs with default frame
> 2. Open a file with font-lock (some mid sized 'C' file)
> 3. Maximize the frame
> 4. scroll down using arrow with the cursor in the 1st column
> 5. On reaching the last line in the visible frame (not file), the crash happens
>
> The following patch fixes this crash (but I do not know why it is NULL):
>
> diff --git a/src/xdisp.c b/src/xdisp.c
> index 47ba85f..f9d34c8 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -6240,6 +6240,12 @@ next_element_from_string (it)
>  {
>   struct text_pos position;
>
> +  /* if string is NULL, nothing much we can do */
> +  if (NULL == it->string)
> +    {
> +      return 0;
> +    }
> +
>   xassert (STRINGP (it->string));
>   xassert (IT_STRING_CHARPOS (*it) >= 0);
>   position = it->current.string_pos;
>
> -dhruva
>
> On Tue, Oct 21, 2008 at 9:12 AM, dhruva <dhruvakm@gmail.com> wrote:
>> Hello,
>>
>> On Mon, Oct 20, 2008 at 8:11 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>> Date: Mon, 20 Oct 2008 18:08:15 +0530
>>>> From: dhruva <dhruvakm@gmail.com>
>>>>
>>>>  I am still seeing the elusive and infrequent crash. I open a 'C'
>>>> file, maximize the frame and use the page down to scroll down or down
>>>> arrow. I keep hitting this crash off and now. The tried getting 'xbt'
>>>> and could not.


-- 
Contents reflect my personal views only!




^ permalink raw reply related	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  5:40     ` dhruva
  2008-10-21  5:58       ` dhruva
@ 2008-10-21  6:38       ` Eli Zaretskii
  2008-10-21  6:41       ` Eli Zaretskii
  2 siblings, 0 replies; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-21  6:38 UTC (permalink / raw)
  To: dhruva; +Cc: emacs-devel

> Date: Tue, 21 Oct 2008 11:10:02 +0530
> From: dhruva <dhruvakm@gmail.com>
> Cc: emacs-devel@gnu.org
> 
> +  /* if string is NULL, nothing much we can do */
> +  if (NULL == it->string)
> +    {
> +      return 0;
> +    }
> +

Thanks, but we need to understand how come it->string became NULL.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  5:40     ` dhruva
  2008-10-21  5:58       ` dhruva
  2008-10-21  6:38       ` Eli Zaretskii
@ 2008-10-21  6:41       ` Eli Zaretskii
  2008-10-21  7:11         ` dhruva
  2 siblings, 1 reply; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-21  6:41 UTC (permalink / raw)
  To: dhruva; +Cc: emacs-devel

> Date: Tue, 21 Oct 2008 11:10:02 +0530
> From: dhruva <dhruvakm@gmail.com>
> Cc: emacs-devel@gnu.org
> 
> Hi,
>  I am now able to reproduce (on M$).
> 1. run emacs with default frame
> 2. Open a file with font-lock (some mid sized 'C' file)
> 3. Maximize the frame
> 4. scroll down using arrow with the cursor in the 1st column
> 5. On reaching the last line in the visible frame (not file), the crash happens

How did you "maximize the frame"?  If it's by clicking the
window-manager button near the upper right corner of the frame, then
your recipe doesn't work for me: I see no crash.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  6:41       ` Eli Zaretskii
@ 2008-10-21  7:11         ` dhruva
  2008-10-21  7:41           ` Juanma Barranquero
  0 siblings, 1 reply; 21+ messages in thread
From: dhruva @ 2008-10-21  7:11 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Hi,

On Tue, Oct 21, 2008 at 12:11 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 21 Oct 2008 11:10:02 +0530
>> From: dhruva <dhruvakm@gmail.com>
>> Cc: emacs-devel@gnu.org
>>
>> Hi,
>>  I am now able to reproduce (on M$).
>> 1. run emacs with default frame
>> 2. Open a file with font-lock (some mid sized 'C' file)
>> 3. Maximize the frame
>> 4. scroll down using arrow with the cursor in the 1st column
>> 5. On reaching the last line in the visible frame (not file), the crash happens
>
> How did you "maximize the frame"?  If it's by clicking the
> window-manager button near the upper right corner of the frame, then
> your recipe doesn't work for me: I see no crash.
>

I use the same button...
I also use the windows message as: (w32-send-sys-command 61488)

If the fix is safe (defensive), IMHO we could get that in as I
continue to debug by adding some extra code in the 'if' block.

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  7:11         ` dhruva
@ 2008-10-21  7:41           ` Juanma Barranquero
  2008-10-21  7:55             ` dhruva
  0 siblings, 1 reply; 21+ messages in thread
From: Juanma Barranquero @ 2008-10-21  7:41 UTC (permalink / raw)
  To: dhruva; +Cc: Eli Zaretskii, emacs-devel

On Tue, Oct 21, 2008 at 09:11, dhruva <dhruvakm@gmail.com> wrote:

> I use the same button...

FWIW, I cannot reproduce it either.

> If the fix is safe (defensive), IMHO we could get that in as I
> continue to debug by adding some extra code in the 'if' block.

IMO is best to let it stand, or even add an assertion; the best way to
catch it is by having it happen.

  Juanma




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  7:41           ` Juanma Barranquero
@ 2008-10-21  7:55             ` dhruva
  2008-10-21  8:03               ` Juanma Barranquero
  2008-10-21  8:30               ` Eli Zaretskii
  0 siblings, 2 replies; 21+ messages in thread
From: dhruva @ 2008-10-21  7:55 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: Eli Zaretskii, emacs-devel

Hello,

On Tue, Oct 21, 2008 at 1:11 PM, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Tue, Oct 21, 2008 at 09:11, dhruva <dhruvakm@gmail.com> wrote:
>
>> I use the same button...
>
> FWIW, I cannot reproduce it either.
>
>> If the fix is safe (defensive), IMHO we could get that in as I
>> continue to debug by adding some extra code in the 'if' block.
>
> IMO is best to let it stand, or even add an assertion; the best way to
> catch it is by having it happen.

Could we just log the required extra information for further debugging
when that happens? Allowing it to crash is a serious inconvenience
(especially  for me since I use the code from HEAD for my regular
work)

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  7:55             ` dhruva
@ 2008-10-21  8:03               ` Juanma Barranquero
  2008-10-21  8:30               ` Eli Zaretskii
  1 sibling, 0 replies; 21+ messages in thread
From: Juanma Barranquero @ 2008-10-21  8:03 UTC (permalink / raw)
  To: dhruva; +Cc: Eli Zaretskii, emacs-devel

On Tue, Oct 21, 2008 at 09:55, dhruva <dhruvakm@gmail.com> wrote:

> Could we just log the required extra information for further debugging
> when that happens?

How do you propose to do that?

> Allowing it to crash is a serious inconvenience
> (especially  for me since I use the code from HEAD for my regular
> work)

YMMV, but IMO HEAD is too unstable for regular work right now.

  Juanma




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  7:55             ` dhruva
  2008-10-21  8:03               ` Juanma Barranquero
@ 2008-10-21  8:30               ` Eli Zaretskii
  2008-10-25 16:51                 ` dhruva
  1 sibling, 1 reply; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-21  8:30 UTC (permalink / raw)
  To: dhruva; +Cc: lekktu, emacs-devel

> Date: Tue, 21 Oct 2008 13:25:38 +0530
> From: dhruva <dhruvakm@gmail.com>
> Cc: "Eli Zaretskii" <eliz@gnu.org>, emacs-devel@gnu.org
> 
> > FWIW, I cannot reproduce it either.
> >
> >> If the fix is safe (defensive), IMHO we could get that in as I
> >> continue to debug by adding some extra code in the 'if' block.
> >
> > IMO is best to let it stand, or even add an assertion; the best way to
> > catch it is by having it happen.

I completely agree with Juanma: your ``defensive'' fix will simply
sweep the problem under the carpet, and it won't get fixed for a long
time, considering that no one can currently reproduce it except
yourself.

> Could we just log the required extra information for further debugging
> when that happens? Allowing it to crash is a serious inconvenience
> (especially  for me since I use the code from HEAD for my regular
> work)

Then please help us debug and fix this ASAP.  TIA




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-21  8:30               ` Eli Zaretskii
@ 2008-10-25 16:51                 ` dhruva
  2008-10-25 16:56                   ` dhruva
  0 siblings, 1 reply; 21+ messages in thread
From: dhruva @ 2008-10-25 16:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, emacs-devel

Hi,

On Tue, Oct 21, 2008 at 2:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 21 Oct 2008 13:25:38 +0530
>> From: dhruva <dhruvakm@gmail.com>
>> Cc: "Eli Zaretskii" <eliz@gnu.org>, emacs-devel@gnu.org
>>
>> > FWIW, I cannot reproduce it either.
>> >
>> >> If the fix is safe (defensive), IMHO we could get that in as I
>> >> continue to debug by adding some extra code in the 'if' block.
>> >
>> > IMO is best to let it stand, or even add an assertion; the best way to
>> > catch it is by having it happen.
>
> I completely agree with Juanma: your ``defensive'' fix will simply
> sweep the problem under the carpet, and it won't get fixed for a long
> time, considering that no one can currently reproduce it except
> yourself.
>
>> Could we just log the required extra information for further debugging
>> when that happens? Allowing it to crash is a serious inconvenience
>> (especially  for me since I use the code from HEAD for my regular
>> work)
>
> Then please help us debug and fix this ASAP.  TIA

I am able to narrow down to the minimum configuration you need in your
.emacs file to get this crash (following the steps I had mentioned
earlier).

I put the following lines in my .emacs, opened xdisp.c file and used
the arrow button to move down the lines. Once the cursor reached the
last visible line, the crash happens (before pulling the new lines
into visible frame).

This crash does not happen with a different font though (like courier)!

(setq inhibit-splash-screen t)
(setq *def-font
  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
(if (boundp '*def-font)
    (add-to-list 'default-frame-alist `(font . ,*def-font)))


-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-25 16:51                 ` dhruva
@ 2008-10-25 16:56                   ` dhruva
  2008-10-27  4:30                     ` dhruva
  0 siblings, 1 reply; 21+ messages in thread
From: dhruva @ 2008-10-25 16:56 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, emacs-devel

Hi,

On Sat, Oct 25, 2008 at 10:21 PM, dhruva <dhruvakm@gmail.com> wrote:
> Hi,
>
> On Tue, Oct 21, 2008 at 2:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> Date: Tue, 21 Oct 2008 13:25:38 +0530
>>> From: dhruva <dhruvakm@gmail.com>
>>> Cc: "Eli Zaretskii" <eliz@gnu.org>, emacs-devel@gnu.org
>>>
>>> > FWIW, I cannot reproduce it either.
>>> >
>>> >> If the fix is safe (defensive), IMHO we could get that in as I
>>> >> continue to debug by adding some extra code in the 'if' block.
>>> >
>>> > IMO is best to let it stand, or even add an assertion; the best way to
>>> > catch it is by having it happen.
>>
>> I completely agree with Juanma: your ``defensive'' fix will simply
>> sweep the problem under the carpet, and it won't get fixed for a long
>> time, considering that no one can currently reproduce it except
>> yourself.
>>
>>> Could we just log the required extra information for further debugging
>>> when that happens? Allowing it to crash is a serious inconvenience
>>> (especially  for me since I use the code from HEAD for my regular
>>> work)
>>
>> Then please help us debug and fix this ASAP.  TIA
>
> I am able to narrow down to the minimum configuration you need in your
> .emacs file to get this crash (following the steps I had mentioned
> earlier).
>
> I put the following lines in my .emacs, opened xdisp.c file and used
> the arrow button to move down the lines. Once the cursor reached the
> last visible line, the crash happens (before pulling the new lines
> into visible frame).
>
> This crash does not happen with a different font though (like courier)!
>
> (setq inhibit-splash-screen t)
> (setq *def-font
>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
> (if (boundp '*def-font)
>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
>

The crash does not happen with (increased the font size by 1 point):
(setq inhibit-splash-screen t)
(setq *def-font
  "-*-Lucida Sans Typewriter-normal-*-*-mono-14-*-*-*-c-*-*-*")
(if (boundp '*def-font)
    (add-to-list 'default-frame-alist `(font . ,*def-font)))

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-25 16:56                   ` dhruva
@ 2008-10-27  4:30                     ` dhruva
  2008-10-27 20:09                       ` Eli Zaretskii
  2008-10-28  8:20                       ` Juanma Barranquero
  0 siblings, 2 replies; 21+ messages in thread
From: dhruva @ 2008-10-27  4:30 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, emacs-devel

Hello,

On Sat, Oct 25, 2008 at 10:26 PM, dhruva <dhruvakm@gmail.com> wrote:
> Hi,
>
> On Sat, Oct 25, 2008 at 10:21 PM, dhruva <dhruvakm@gmail.com> wrote:

>> I am able to narrow down to the minimum configuration you need in your
>> .emacs file to get this crash (following the steps I had mentioned
>> earlier).
>>
>> I put the following lines in my .emacs, opened xdisp.c file and used
>> the arrow button to move down the lines. Once the cursor reached the
>> last visible line, the crash happens (before pulling the new lines
>> into visible frame).
>>
>> This crash does not happen with a different font though (like courier)!
>>
>> (setq inhibit-splash-screen t)
>> (setq *def-font
>>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
>> (if (boundp '*def-font)
>>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
>>
>
> The crash does not happen with (increased the font size by 1 point):
> (setq inhibit-splash-screen t)
> (setq *def-font
>  "-*-Lucida Sans Typewriter-normal-*-*-mono-14-*-*-*-c-*-*-*")
> (if (boundp '*def-font)
>    (add-to-list 'default-frame-alist `(font . ,*def-font)))

Could anyone reproduce the crash? Due to lack of knowledge of the
display source code, I am not able to further analyze.

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-27  4:30                     ` dhruva
@ 2008-10-27 20:09                       ` Eli Zaretskii
  2008-10-28  4:00                         ` dhruva
  2008-10-28  8:20                       ` Juanma Barranquero
  1 sibling, 1 reply; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-27 20:09 UTC (permalink / raw)
  To: dhruva; +Cc: lekktu, emacs-devel

> Date: Mon, 27 Oct 2008 10:00:33 +0530
> From: dhruva <dhruvakm@gmail.com>
> Cc: lekktu@gmail.com, emacs-devel@gnu.org
> 
> >> I put the following lines in my .emacs, opened xdisp.c file and used
> >> the arrow button to move down the lines. Once the cursor reached the
> >> last visible line, the crash happens (before pulling the new lines
> >> into visible frame).
> >>
> >> This crash does not happen with a different font though (like courier)!
> >>
> >> (setq inhibit-splash-screen t)
> >> (setq *def-font
> >>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
> >> (if (boundp '*def-font)
> >>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
> >>
> >
> > The crash does not happen with (increased the font size by 1 point):
> > (setq inhibit-splash-screen t)
> > (setq *def-font
> >  "-*-Lucida Sans Typewriter-normal-*-*-mono-14-*-*-*-c-*-*-*")
> > (if (boundp '*def-font)
> >    (add-to-list 'default-frame-alist `(font . ,*def-font)))
> 
> Could anyone reproduce the crash? Due to lack of knowledge of the
> display source code, I am not able to further analyze.

Can you reproduce the crash if, instead of putting the above in
.emacs, you put it in a file named foo.el and invoke Emacs like this:

   emacs -Q -l foo.el

or maybe even "emacs -Q" and then "M-x load-file RET foo.el RET"?  I'm
asking because it's a hassle to move aside my .emacs and/or edit it.
Doing this with a different file starting from "emacs -Q" is much more
convenient.




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-27 20:09                       ` Eli Zaretskii
@ 2008-10-28  4:00                         ` dhruva
  0 siblings, 0 replies; 21+ messages in thread
From: dhruva @ 2008-10-28  4:00 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, emacs-devel

Hi,

On Tue, Oct 28, 2008 at 1:39 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 27 Oct 2008 10:00:33 +0530
>> From: dhruva <dhruvakm@gmail.com>
>> Cc: lekktu@gmail.com, emacs-devel@gnu.org
>>
>> >> I put the following lines in my .emacs, opened xdisp.c file and used
>> >> the arrow button to move down the lines. Once the cursor reached the
>> >> last visible line, the crash happens (before pulling the new lines
>> >> into visible frame).
>> >>
>> >> This crash does not happen with a different font though (like courier)!
>> >>
>> >> (setq inhibit-splash-screen t)
>> >> (setq *def-font
>> >>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
>> >> (if (boundp '*def-font)
>> >>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
>> >>
>> >
>> > The crash does not happen with (increased the font size by 1 point):
>> > (setq inhibit-splash-screen t)
>> > (setq *def-font
>> >  "-*-Lucida Sans Typewriter-normal-*-*-mono-14-*-*-*-c-*-*-*")
>> > (if (boundp '*def-font)
>> >    (add-to-list 'default-frame-alist `(font . ,*def-font)))
>>
>> Could anyone reproduce the crash? Due to lack of knowledge of the
>> display source code, I am not able to further analyze.
>
> Can you reproduce the crash if, instead of putting the above in
> .emacs, you put it in a file named foo.el and invoke Emacs like this:

Yes, I tested it that way by putting it in a different file and
invoking emacs as:
emacs -Q -l file_with_above_lines

-dhruva

-- 
Contents reflect my personal views only!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-27  4:30                     ` dhruva
  2008-10-27 20:09                       ` Eli Zaretskii
@ 2008-10-28  8:20                       ` Juanma Barranquero
  2008-10-28 18:42                         ` Eli Zaretskii
  1 sibling, 1 reply; 21+ messages in thread
From: Juanma Barranquero @ 2008-10-28  8:20 UTC (permalink / raw)
  To: dhruva; +Cc: Eli Zaretskii, emacs-devel

On Mon, Oct 27, 2008 at 05:30, dhruva <dhruvakm@gmail.com> wrote:

>> This crash does not happen with a different font though (like courier)!
>>
>> (setq inhibit-splash-screen t)
>> (setq *def-font
>>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
>> (if (boundp '*def-font)
>>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
[...]
> Could anyone reproduce the crash?

I can not try to reproduce it, as I don't have Lucida Sans Typewriter.

  Juanma




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-28  8:20                       ` Juanma Barranquero
@ 2008-10-28 18:42                         ` Eli Zaretskii
  2008-10-29  2:28                           ` Stephen J. Turnbull
  0 siblings, 1 reply; 21+ messages in thread
From: Eli Zaretskii @ 2008-10-28 18:42 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: emacs-devel

> Date: Tue, 28 Oct 2008 09:20:52 +0100
> From: "Juanma Barranquero" <lekktu@gmail.com>
> Cc: "Eli Zaretskii" <eliz@gnu.org>, emacs-devel@gnu.org
> 
> On Mon, Oct 27, 2008 at 05:30, dhruva <dhruvakm@gmail.com> wrote:
> 
> >> This crash does not happen with a different font though (like courier)!
> >>
> >> (setq inhibit-splash-screen t)
> >> (setq *def-font
> >>  "-*-Lucida Sans Typewriter-normal-*-*-mono-13-*-*-*-c-*-*-*")
> >> (if (boundp '*def-font)
> >>    (add-to-list 'default-frame-alist `(font . ,*def-font)))
> [...]
> > Could anyone reproduce the crash?
> 
> I can not try to reproduce it, as I don't have Lucida Sans Typewriter.

Neither do I (it's an Adobe font that needs to be purchased).

Can the problem be reproduced with one of the standard Windows fonts?




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-28 18:42                         ` Eli Zaretskii
@ 2008-10-29  2:28                           ` Stephen J. Turnbull
  2008-10-29  6:39                             ` Werner LEMBERG
  0 siblings, 1 reply; 21+ messages in thread
From: Stephen J. Turnbull @ 2008-10-29  2:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii writes:

 > > I can not try to reproduce it, as I don't have Lucida Sans Typewriter.
 > 
 > Neither do I (it's an Adobe font that needs to be purchased).

Probably not.  In my experience, while Adobe legal has been more than
obnoxious in protection of "their" "property", Adobe technical is
generally sympathetic to the idea that open standards imply "open
source" implementations, and that if free implementations exist, it's
better for them to be good ones.

Probably all you need to do is write to Adobe, explain that their
product has been implicated in a crash of FreeType (not just
Emacs<wink>), and request a complimentary copy for development
purposes.

Surely somebody on this list has an acquaintance at Adobe, who will
see that this makes sense and vouch to whoever needs to sign off that
(a) they aren't going to get an additional sale by withholding this
copy and (b) Emacs developers aren't going to go around infringing
copyright by redistributing it.  If not, a message from Stefan or
Yidong as maintainer should do the trick.





^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Emacs (HEAD) crash on M$ (XP) built with MinGW
  2008-10-29  2:28                           ` Stephen J. Turnbull
@ 2008-10-29  6:39                             ` Werner LEMBERG
  0 siblings, 0 replies; 21+ messages in thread
From: Werner LEMBERG @ 2008-10-29  6:39 UTC (permalink / raw)
  To: stephen; +Cc: eliz, emacs-devel


> Probably all you need to do is write to Adobe, explain that their
> product has been implicated in a crash of FreeType (not just
> Emacs<wink>), and request a complimentary copy for development
> purposes.

I really doubt that Lucida causes a crash with the recent FreeType
version (2.3.7).  If you find that this is really the case, please
report it to the FreeType people (this is, me :-).


    Werner




^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2008-10-29  6:39 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20 12:38 Emacs (HEAD) crash on M$ (XP) built with MinGW dhruva
2008-10-20 14:41 ` Eli Zaretskii
2008-10-21  3:42   ` dhruva
2008-10-21  5:40     ` dhruva
2008-10-21  5:58       ` dhruva
2008-10-21  6:38       ` Eli Zaretskii
2008-10-21  6:41       ` Eli Zaretskii
2008-10-21  7:11         ` dhruva
2008-10-21  7:41           ` Juanma Barranquero
2008-10-21  7:55             ` dhruva
2008-10-21  8:03               ` Juanma Barranquero
2008-10-21  8:30               ` Eli Zaretskii
2008-10-25 16:51                 ` dhruva
2008-10-25 16:56                   ` dhruva
2008-10-27  4:30                     ` dhruva
2008-10-27 20:09                       ` Eli Zaretskii
2008-10-28  4:00                         ` dhruva
2008-10-28  8:20                       ` Juanma Barranquero
2008-10-28 18:42                         ` Eli Zaretskii
2008-10-29  2:28                           ` Stephen J. Turnbull
2008-10-29  6:39                             ` Werner LEMBERG

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).