unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: dhruva <dhruvakm@gmail.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Build failure on M$ (using MSVC): Patch enclosed
Date: Thu, 22 May 2008 12:26:11 +0530	[thread overview]
Message-ID: <e3f230850805212356h304d7c18gdc8416491617fa62@mail.gmail.com> (raw)
In-Reply-To: <e3f230850805212203i565b90r931d539761c43342@mail.gmail.com>

Hi,
 For fixing the build failure on M$ in src/font.c, there is a more
elegant alternative approach.

1. Remove the "#include <strings.h>" from that file
2. Define HAVE_STRINGS_H if using GCC or define HAVE_STRING_H if using
MSVC. src/config.h and nt/config.nt both include string/strings header
based on the above define.
3. Retain the strcasecmp to stricmp in src/s/ms-w32.h

-dhruva

-- 
Contents reflect my personal views only!




  parent reply	other threads:[~2008-05-22  6:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  4:58 Build failure on M$ (using MSVC): Patch enclosed dhruva
2008-05-20  6:10 ` dhruva
2008-05-20  8:26   ` dhruva
2008-05-20  8:58     ` dhruva
2008-05-20  9:46       ` Jason Rumney
2008-05-20 10:21         ` David Kastrup
2008-05-20 11:57           ` dhruva
2008-05-20 12:01             ` dhruva
2008-05-20 18:26       ` Eli Zaretskii
2008-05-20 12:11     ` Herbert Euler
2008-05-20 18:30       ` Eli Zaretskii
2008-05-20 18:12 ` Eli Zaretskii
2008-05-21  3:13   ` dhruva
2008-05-21 17:28     ` Stefan Monnier
2008-05-22  3:51       ` dhruva
2008-05-22  4:46         ` Stefan Monnier
2008-05-22  5:03           ` dhruva
2008-05-22  6:52             ` David Kastrup
2008-05-22  7:10               ` dhruva
2008-05-22  7:32                 ` David Kastrup
2008-05-22 15:49                 ` Stefan Monnier
2008-05-22 15:45               ` Stefan Monnier
2008-05-22  6:56             ` dhruva [this message]
2008-05-23  8:30               ` Eli Zaretskii
2008-05-23  9:15                 ` Jason Rumney
2008-05-22  8:32         ` Jason Rumney
2008-05-22  9:10           ` dhruva
2008-05-22  9:29             ` dhruva
2008-05-22 12:31               ` Jason Rumney
2008-05-22 13:10                 ` Jason Rumney
2008-05-22 13:33                   ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f230850805212356h304d7c18gdc8416491617fa62@mail.gmail.com \
    --to=dhruvakm@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).