From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: dhruva Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Thu, 22 May 2008 10:33:40 +0530 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1211432651 15452 80.91.229.12 (22 May 2008 05:04:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 May 2008 05:04:11 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 22 07:04:46 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jz2ym-0004Nx-1M for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 07:04:40 +0200 Original-Received: from localhost ([127.0.0.1]:37303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz2y1-0001wX-P8 for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 01:03:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jz2xv-0001wS-Ju for emacs-devel@gnu.org; Thu, 22 May 2008 01:03:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jz2xq-0001wG-To for emacs-devel@gnu.org; Thu, 22 May 2008 01:03:46 -0400 Original-Received: from [199.232.76.173] (port=36336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz2xq-0001wD-Ju for emacs-devel@gnu.org; Thu, 22 May 2008 01:03:42 -0400 Original-Received: from ti-out-0910.google.com ([209.85.142.190]:15659) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jz2xp-00074e-RR for emacs-devel@gnu.org; Thu, 22 May 2008 01:03:42 -0400 Original-Received: by ti-out-0910.google.com with SMTP id u5so2460206tia.10 for ; Wed, 21 May 2008 22:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=kywpFq04KYN8NuYDKKh+yAwDg1WMHhIRvQhsbCM3leM=; b=Z8ywkIOKZSv9zFKXor118cng0EfjSbKPbOrCuKz7neWchJ+R4DXIoKMd7mRxez+cx2ePhfY1y+0qTQ2BBoH6okVL5l+fQ1LUqOhDpUYFers3RymEfs31OU2fhUM6hOpuE/wefs7T1yDDlY3Wlit7UbNiKFApcXJXq55ub2VqIWI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=fzNvpzvuhqUJzG6mmx+fQZFCC+d9JQWRgvDPUaKjBX7cS28I1qapECCmImP0xJzVFD0WdwS1POcIBZ18yT9dKfCi+ME7Xt6VFidsD+J5cR2xbV2P2ozUWL3AToTq3kcCEarfzuUQKCckefThtHRbv/13g794EFAjKof5BFxq15E= Original-Received: by 10.110.57.6 with SMTP id f6mr1374176tia.35.1211432620214; Wed, 21 May 2008 22:03:40 -0700 (PDT) Original-Received: by 10.110.90.17 with HTTP; Wed, 21 May 2008 22:03:40 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97502 Archived-At: On 5/22/08, Stefan Monnier wrote: > > Well, I was not aware of that function. Looking a little deeper into > > it, it does not traverse above the current user $HOME (~/ or %HOME%). > > This code needs to go all the way till the top. Since it does a > > username comparison, it apprears a bit more expensive (based on gut > > feel though). > > > Indeed, it doesn't go up past the home directory and it doesn't lookup > past a directory with a different owner. It's all done on purpose to > try and avoid pathological cases. > I don't see that as a problem at all. Though I do not see a practical use case, here is a case where it can fail: 1. As a system wide policy, I put some settings file in the root folder or the parent folder of every user folder which has a bunch of defaults 2. I allow the use to over ride it by adding their own in which case your changes will find the user modified file (as it resides under the user HOME folder on UNIX because users will not have permission to create anywhere above that. But not true on M$ as I have local admin privilege and hence I can keep it anywhere in the tree). 3. Not all users might want to over ride the default settings and would like to rely on the system wide policy where the current code fails. -dhruva -- Contents reflect my personal views only!