From: dhruva <dhruvakm@gmail.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Build failure on M$ (using MSVC): Patch enclosed
Date: Thu, 22 May 2008 09:21:54 +0530 [thread overview]
Message-ID: <e3f230850805212051t317199b4r3090e42705a9970c@mail.gmail.com> (raw)
In-Reply-To: <jwvlk23pnyn.fsf-monnier+emacs@gnu.org>
Hi,
On 5/21/08, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > diff --git a/lisp/files.el b/lisp/files.el
> > index ee5efe4..bb8a021 100644
> > --- a/lisp/files.el
> > +++ b/lisp/files.el
> > @@ -3120,8 +3120,9 @@ If the file is in a registered project, a cons from
> > `project-directory-alist' is returned.
> > Otherwise this returns nil."
> > (let ((dir (file-name-directory file))
> > - (result nil))
> > - (while (and (not (string= dir "/"))
> > + (result nil)
> > + (prevdir nil))
> > + (while (and (not (string= dir prevdir))
> > (not result))
> > (cond
> > ((setq result (assoc dir project-directory-alist))
> > @@ -3130,6 +3131,7 @@ Otherwise this returns nil."
> > ((file-exists-p (expand-file-name ".dir-settings.el" dir))
> > (setq result (expand-file-name ".dir-settings.el" dir)))
> > (t
> > + (setq prevdir dir)
> > (setq dir (file-name-directory (directory-file-name dir))))))
> > result))
>
>
> Actually, why doesn't this code use locate-dominating-file?
Well, I was not aware of that function. Looking a little deeper into
it, it does not traverse above the current user $HOME (~/ or %HOME%).
This code needs to go all the way till the top. Since it does a
username comparison, it apprears a bit more expensive (based on gut
feel though).
my HOME is set to: c:/users/dhruva
My lisp expresssion: (locate-dominating-file
"c:/users/dhruva/stub/git/emacs/" ".dir-settings.el")
1. I place the .dir-settings.el under "C:/" and I get a nil
2. I move the file under HOME (c:/users/dhruva/.dir-settings.el) and get it.
=> It does not traverse beyond the HOME directory.
-dhruva
--
Contents reflect my personal views only!
next prev parent reply other threads:[~2008-05-22 3:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:58 Build failure on M$ (using MSVC): Patch enclosed dhruva
2008-05-20 6:10 ` dhruva
2008-05-20 8:26 ` dhruva
2008-05-20 8:58 ` dhruva
2008-05-20 9:46 ` Jason Rumney
2008-05-20 10:21 ` David Kastrup
2008-05-20 11:57 ` dhruva
2008-05-20 12:01 ` dhruva
2008-05-20 18:26 ` Eli Zaretskii
2008-05-20 12:11 ` Herbert Euler
2008-05-20 18:30 ` Eli Zaretskii
2008-05-20 18:12 ` Eli Zaretskii
2008-05-21 3:13 ` dhruva
2008-05-21 17:28 ` Stefan Monnier
2008-05-22 3:51 ` dhruva [this message]
2008-05-22 4:46 ` Stefan Monnier
2008-05-22 5:03 ` dhruva
2008-05-22 6:52 ` David Kastrup
2008-05-22 7:10 ` dhruva
2008-05-22 7:32 ` David Kastrup
2008-05-22 15:49 ` Stefan Monnier
2008-05-22 15:45 ` Stefan Monnier
2008-05-22 6:56 ` dhruva
2008-05-23 8:30 ` Eli Zaretskii
2008-05-23 9:15 ` Jason Rumney
2008-05-22 8:32 ` Jason Rumney
2008-05-22 9:10 ` dhruva
2008-05-22 9:29 ` dhruva
2008-05-22 12:31 ` Jason Rumney
2008-05-22 13:10 ` Jason Rumney
2008-05-22 13:33 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f230850805212051t317199b4r3090e42705a9970c@mail.gmail.com \
--to=dhruvakm@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).