build error on HEAD (set_tty_color_mode: undefined symbol)

build error on HEAD (set_tty_color_mode: undefined symbol)

[dhruva]

Hi,
 The xdisp.c code has a call to set_tty_color_mode function that is
not compiled on Windoze (WINDOWSNT) in term.c. Either it should be
compiled or the call needs to be in a guard (#ifndef WINDOWSNT). Since
I do not know which is correct, I am just reporting it.

-dhruva

-- 
Contents reflect my personal views only!

Re: build error on HEAD (set_tty_color_mode: undefined symbol)

[dhruva]

Hi,
 The following patch appears to fix the issue (I am using GIT, hence
this could be fixed before the git mirror syncs)

diff --git a/src/term.c b/src/term.c
index f76d0a5..4e640bb 100644
--- a/src/term.c
+++ b/src/term.c
@@ -2072,8 +2072,6 @@ is not on a tty device.  */)
     return make_number (t->display_info.tty->TN_max_colors);
 }

-#ifndef WINDOWSNT
-
 /* Declare here rather than in the function, as in the rest of Emacs,
    to work around an HPUX compiler bug (?). See
    http://lists.gnu.org/archive/html/emacs-devel/2007-08/msg00410.html  */
@@ -2196,8 +2194,6 @@ set_tty_color_mode (tty, f)
     }
 }

-#endif /* !WINDOWSNT */
-

On Thu, Apr 10, 2008 at 9:11 AM, dhruva <dhruvakm@gmail.com> wrote:
> Hi,
>   The xdisp.c code has a call to set_tty_color_mode function that is
>  not compiled on Windoze (WINDOWSNT) in term.c. Either it should be
>  compiled or the call needs to be in a guard (#ifndef WINDOWSNT). Since
>  I do not know which is correct, I am just reporting it.


-- 
Contents reflect my personal views only!

Re: build error on HEAD (set_tty_color_mode: undefined symbol)

[Jason Rumney]

dhruva wrote:
> Hi,
>  The xdisp.c code has a call to set_tty_color_mode function that is
> not compiled on Windoze (WINDOWSNT) in term.c. Either it should be
> compiled or the call needs to be in a guard (#ifndef WINDOWSNT). Since
> I do not know which is correct, I am just reporting it.
>   

I fixed that yesterday.