Re: Recent changes incorrectly calculate font size within daemon mode

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Michael Heerdegen wrote:
> The crucial difference seems to be that in an older Emacs build I get
> 
> (assq 'font (frame-parameters))
> ==>
>   (font . "-PfEd-DejaVu Sans Mono-normal-normal-normal-*-23-*-*-*-m-0-iso10646-1")
> 
> and with current master
> 
> (assq 'font (frame-parameters))
> ==>
>   (font . "-PfEd-DejaVu Sans Mono-normal-normal-normal-*-*-*-*-*-m-0-iso10646-1")

Thanks for narrowing that down; it was quite helpful. I installed the attached 
patch into Emacs master; please give it a try.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-off-by-1-typo-in-recent-bignum-changes.patch --]
[-- Type: text/x-patch; name="0001-Fix-off-by-1-typo-in-recent-bignum-changes.patch", Size: 1140 bytes --]

From 260e695dedd1cf9b9815a38e6b3369319b97b5f9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 30 Aug 2018 14:28:19 -0700
Subject: [PATCH] Fix off-by-1 typo in recent bignum changes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem reported by Yuri D’Elia in:
https://lists.gnu.org/r/emacs-devel/2018-08/msg00977.html
and crucial clue provided by Michael Heerdegen in:
https://lists.gnu.org/r/emacs-devel/2018-08/msg01043.html
* src/font.c (font_unparse_xlfd): Fix off-by-1 typo.
---
 src/font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/font.c b/src/font.c
index 4a63700f79..e2414582f6 100644
--- a/src/font.c
+++ b/src/font.c
@@ -1290,7 +1290,7 @@ font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes)
   if (INTEGERP (val))
     {
       intmax_t v = FIXNUMP (val) ? XFIXNUM (val) : bignum_to_intmax (val);
-      if (! (0 <= v && v <= TYPE_MAXIMUM (uprintmax_t)))
+      if (! (0 < v && v <= TYPE_MAXIMUM (uprintmax_t)))
 	v = pixel_size;
       if (v > 0)
 	{
-- 
2.17.1