From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Sat, 2 Dec 2017 10:50:24 +0000 Message-ID: References: <20171129233237.27462.23351@vcs0.savannah.gnu.org> <20171129233238.504B5204F1@vcs0.savannah.gnu.org> <5d668ce5-1482-a3d4-c01b-7d996a532567@yandex.ru> <20171130214621.GA22157@ACM> <27985594-3bb4-ce88-8928-2ccfeac13eae@yandex.ru> <20171201154913.GB3840@ACM> <1e542021-e389-cca4-6acd-349efddb2652@yandex.ru> <20171201223529.GG3840@ACM> <4a94ec5c-efdd-50f1-ff4d-277f5f45c2df@yandex.ru> <83lgil1qme.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1512211842 9199 195.159.176.226 (2 Dec 2017 10:50:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Dec 2017 10:50:42 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 Cc: acm@muc.de, tom@tromey.com, monnier@iro.umontreal.ca, spinuvit@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 02 11:50:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL5NQ-0001rW-QK for ged-emacs-devel@m.gmane.org; Sat, 02 Dec 2017 11:50:32 +0100 Original-Received: from localhost ([::1]:35108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL5NY-0006u8-5G for ged-emacs-devel@m.gmane.org; Sat, 02 Dec 2017 05:50:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL5NR-0006tp-3m for emacs-devel@gnu.org; Sat, 02 Dec 2017 05:50:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL5NN-0000Bh-5v for emacs-devel@gnu.org; Sat, 02 Dec 2017 05:50:33 -0500 Original-Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:40597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL5NM-0000BA-VS; Sat, 02 Dec 2017 05:50:29 -0500 Original-Received: by mail-wm0-x232.google.com with SMTP id f206so929428wmf.5; Sat, 02 Dec 2017 02:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RChNdCoyETU5JZhL6U95ZlIlpSvydR/RGY0kLiqsdlA=; b=NJNZrJXAnLT8u6UwE4eEaN2QDG2WMhNbgCWuVbFywaEUosRQYlFz2pyNkc2lrG51TW 6WmCFEaHoI15eWQCogKnSaFaJjw1AUSy8YsZuWyuZfwhdB0E8yT86Pb8TvExAJ1GzMUd Q47FviSn07ioMEneIMEc93FfdYodgU3T4Zm1AFCtJoB5QrZ72aUCIk0zz24zKa9u0OM5 928BM+ozq2Xq4fE2TqasjGCssPz46JHna10zstDgNUFX82pb8R6PqBVH+Q7qM5ojkA4T TnTrkqIcIAP3xYwJW1/PILE5St4L8t7Qt2m12SP2MIYJSYASzjPaNVQheVERtG+AlAI7 n4CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RChNdCoyETU5JZhL6U95ZlIlpSvydR/RGY0kLiqsdlA=; b=cEOyy/3eBvvCCjRVigarQ0iXDuo/yMkyBUL2vIynV3z8SHbsBylrx7KyJGBGMFROE2 v3nYRDwoJXU4BZP+vpLJn+muLEUQvM8dGFfsXCrwNxGfbGT7hJHs3A7qz9FhYoqiFV3f fxAIkEzdJcaMlObVzpqSUJvq71eXHOQevh7Nm+TpiU7MEi7H0D9+zHqE9bzt3kLkr3dl ie1myPP9FttrDtX3X9iyf/dxt6nZKw3Ei+Sx1Fv5jXichMgbrheLNvoBJdtgtV+1yEOj YpbQDmt0d4P6qiVqSQ2+Jp+AdjOkUyU8h51vVU6rzGKFKjhJxUTPpvJIwBqfSGZRcmDY L5vQ== X-Gm-Message-State: AJaThX5a6AWmmN9yyZiiiE2IOr/ir6j9DmZR82MMRP4Sy9pqWFhmEIcZ a37oD4Ug1V9E/vjKSZwagZ3+38pi X-Google-Smtp-Source: AGs4zMbNDqnO1iVzqK4pYFQFb7EObr6/waQpkIQ4+wDBXTbwXmjY9VlbArDAKyqzaKpcqLLnSd0Nng== X-Received: by 10.28.141.11 with SMTP id p11mr3401986wmd.149.1512211827498; Sat, 02 Dec 2017 02:50:27 -0800 (PST) Original-Received: from [192.168.1.38] (89-160-235-67.du.xdsl.is. [89.160.235.67]) by smtp.googlemail.com with ESMTPSA id h8sm3072917wme.30.2017.12.02.02.50.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Dec 2017 02:50:26 -0800 (PST) In-Reply-To: <83lgil1qme.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220613 Archived-At: On 12/2/17 8:27 AM, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Fri, 1 Dec 2017 23:24:28 +0000 >> Cc: Tom Tromey , Stefan Monnier , >> Vitalie Spinu , emacs-devel@gnu.org >> >> Like mentioned, for most major mode the changes are trivial, if at all >> needed. > > IMO, C modes and Lisp modes must be supported well, before this lands > on master. Why? Web languages are a lot more common in mixed mode buffers (think HTML files and templates), so it's a lot more important to have that support in them (and we already do). Lisp modes should work already too, because lisp-indent-line doesn't call widen. And about C, first, it's much harder for different reasons, two, we'd have to spend more time convincing its author. And then we'd have to fix other MMM-related problems in it that the other mentioned modes don't have. And, I'm sorry about this, but I want to land these changes in emacs-26, for one main reason: it simplifies, reworks and replaces the prog-indentation-context feature, which is not in Emacs 25. At one point we/I removed it from Emacs 25 for reasons of being undercooked, but didn't merge that change to then-master. And then kind of forgot. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28475#11 was a later reminder. This way, the "widen less" proposal could be considered a "bug fix", if we stretch the definition far enough. And also, the new approach is pretty small, it removes more code than adds.