From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Please add comments to isearch.el Date: Sat, 12 Dec 2015 08:20:49 -0800 (PST) Message-ID: References: <<83fuzoojcn.fsf@gnu.org>> <<83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box>> <<83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net>> <<83d1uc6sdq.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1449937293 24460 80.91.229.3 (12 Dec 2015 16:21:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Dec 2015 16:21:33 +0000 (UTC) Cc: acm@muc.de, bruce.connor.am@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 12 17:21:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7mv4-0001Gz-EZ for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 17:21:14 +0100 Original-Received: from localhost ([::1]:52297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7mv3-0000yE-Hp for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 11:21:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7mup-0000xl-5B for emacs-devel@gnu.org; Sat, 12 Dec 2015 11:21:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7muo-0000QV-8d for emacs-devel@gnu.org; Sat, 12 Dec 2015 11:20:59 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:27986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7muk-0000Q8-A1; Sat, 12 Dec 2015 11:20:54 -0500 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tBCGKqHv017549 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 12 Dec 2015 16:20:52 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tBCGKptt009922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 12 Dec 2015 16:20:52 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tBCGKpND024410; Sat, 12 Dec 2015 16:20:51 GMT In-Reply-To: <<83d1uc6sdq.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196165 Archived-At: > > > The point is that Isearch is probably one of the most used emacs > > > features. I expect there are lots of packages out there using > > > its api. I'm not sure overhauling it would be worth the pain it > > > would cause to everyone who's maintaining/using those packages. > > > > +1 > > > > For example, the recent removal of a layer of indirection for > > lax-whitespace broke customizations that allowed overriding > > search-forward-lax-whitespace with own implementation to ignore > > all possible whitespace instead of just spaces in the search string. >=20 > Hey, I didn't suggest refactoring to begin with. I suggested to add > commentary to explain how things work there. The example you give is > just another confirmation of my observation that the code in > isearch.el has long ago crossed the line of being unmaintainable, and > I think we should fix that ASAP. FWIW: My +1 above was for caution wrt a major rewrite of the code, not wrt minor cleanup that improves readability and clearly does not affect behavior or (preferably) compatibility with the previous code. And as I said before that, +1 especially for adding the design comments that Eli has requested. And +1 to his suggestion ("to begin with") that such commenting should come before any code cleanup. (Any such comments will also help with any subsequent proposed code cleanup and discussions about it.)