ERC: header-line-format nil

ERC: header-line-format nil

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

When `erc-header-line-format' is set to nil, the header line should  
not be set in order to avoid interfering with minor modes that may use  
it (e.g., tabbar).  Is it OK to apply the patch below?




*** erc.el	28 Jul 2008 23:15:49 +0100	1.52
--- erc.el	17 Aug 2008 19:44:33 +0100	
***************
*** 6085,6092 ****
   	(let ((header (if erc-header-line-format
   			  (format-spec erc-header-line-format spec)
   			nil)))
! 	  (cond ((null header)
! 		 (setq header-line-format nil))
   		(erc-header-line-uses-help-echo-p
   		 (let ((help-echo (with-temp-buffer
   				    (insert header)
--- 6085,6091 ----
   	(let ((header (if erc-header-line-format
   			  (format-spec erc-header-line-format spec)
   			nil)))
! 	  (cond ((null header))
   		(erc-header-line-uses-help-echo-p
   		 (let ((help-echo (with-temp-buffer
   				    (insert header)


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

Re: ERC: header-line-format nil

[Michael Olson]

On Sun, 17 Aug 2008 19:46:13 +0100, David Reitter <david.reitter@gmail.com>
wrote:
> When `erc-header-line-format' is set to nil, the header line should
> not be set in order to avoid interfering with minor modes that may use
> it (e.g., tabbar).  Is it OK to apply the patch below?

Don't apply this just yet.  I won't be able to review it until at least
Wednesday.  I recall an emacswiki page describing how to integrate tabbar
with ERC -- it might be good to know whether that page has a similar
workaround, or whether they take a different approach.

-- 
|       Michael Olson  |  FSF Associate Member #652     |
| http://mwolson.org/  |  Hobbies: Lisp, HCoop          |
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`-------------------------------------------------------'

Re: ERC: header-line-format nil

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

On 17 Aug 2008, at 19:57, Michael Olson wrote:
>
>   I recall an emacswiki page describing how to integrate tabbar
> with ERC -- it might be good to know whether that page has a similar
> workaround, or whether they take a different approach.


Found it, but all they do is to run tabbar-local-mode, which overrides  
`header-line-format' after ERC has been entered, so that's really just  
a workaround.

What ERC could do is to only set `header-line-format' if it isn't  
already set in the buffer (by another package).  This, however, might  
not be the right solution in all cases.

I wouldn't invest much time into this - the "right thing" would be to  
implement tabbars at the C level.

- D

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]