From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt Newsgroups: gmane.emacs.devel Subject: Re: bytecomp-tests still failing after Mattias' commit a3db503351e9 Date: Fri, 3 Nov 2023 21:25:00 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 03 21:26:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qz0kT-0004gP-Ky for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Nov 2023 21:26:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qz0ja-0007Ka-L2; Fri, 03 Nov 2023 16:25:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qz0jY-0007KH-Cv for emacs-devel@gnu.org; Fri, 03 Nov 2023 16:25:37 -0400 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qz0jU-0003AI-4c for emacs-devel@gnu.org; Fri, 03 Nov 2023 16:25:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1699043117; bh=LwchqCzox1MWpY5MZg0fmVRXUy/DLchjYIOpd4cK2rQ=; h=Message-ID:Date:User-Agent:Subject:From:To:References: Content-Language:In-Reply-To:Content-Type:From; b=WMZlZvMjtyfpCdp2KQ1l+/xFqoe5QtfkEEK5nUnwjdJVAF4L8vZhDzYgPPfltVtXY K1Q4zczsAr/OEBEtVv5Y4WKd61Y83hSxs7Wr87HUHb5BG+/KgTCiQ2F/wDhQeqPqpF QwErv4+2ETH/GLVUXvHnlnZXB7PGZlWJ2IuWsZAY= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4SMXL564w4z1yDr; Fri, 3 Nov 2023 20:25:17 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-196-48-191.dynamic.as20676.net [92.196.48.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4SMXKy3jpmzMks2; Fri, 3 Nov 2023 20:25:07 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: X-purgate-type: clean X-purgate: clean X-purgate-size: 4127 X-purgate-ID: 155817::1699043113-F1FFB228-D6DA679A/0/0 Received-SPF: pass client-ip=145.253.228.165; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr5.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312176 Archived-At: Changing subject (which I forgot last time) to catch Mattias' attention. Mattias, could you please have a look? Nothing has changed as of today's commit 6218278a67b5ce87eb5e8b2c76daeb7475983d35, this one test is still failing. If you'd like to reproduce, you probably need to install package bubblewrap or whatever provides "bwrap" on your distribution. Provided you use GNU/Linux ... Thanks. On 2023-10-30 21:24, Jens Schmidt wrote: > This got much better (thanks), I'm down to one failing unit test now. > And I think this last one is due to commit a3db503351e9 by Mattias. > That commit should probably add the lexical bindings line in the > mountpoint case, like this, which fixes the failure for me: > > diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el > index 4aa555f1e92..06918f5901c 100644 > --- a/test/lisp/emacs-lisp/bytecomp-tests.el > +++ b/test/lisp/emacs-lisp/bytecomp-tests.el > @@ -1697,7 +1697,8 @@ bytecomp-tests--dest-mountpoint > (byte-compile-error-on-warn t)) > (should-not (file-remote-p input-file)) > (should-not (file-remote-p output-file)) > - (write-region "" nil input-file nil nil nil 'excl) > + (write-region ";;; -*-lexical-binding:t-*-\n" > + nil input-file nil nil nil 'excl) > (write-region "" nil output-file nil nil nil 'excl) > (unwind-protect > (progn > > (Seems that I happen to have this "bwrap" thingy installed, otherwise that > test gets skipped and may slip through.) > > The failing test looks like this, if it matters: > > ------------------------- snip ------------------------- > In end of data: > Warning: the function `an-undefined-function' is not known to be defined. > passed 15/99 bytecomp-test-featurep-warnings (0.000353 sec) > Test bytecomp-tests--dest-mountpoint backtrace: > signal(ert-test-failed (((status . 1) (output . ">>Error occurred pr > ert-fail(((status . 1) (output . ">>Error occurred processing /tmp/e > (if (eql status 0) nil (ert-fail (list (cons 'status status) (cons ' > (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "/" "--b > (progn (let ((status (call-process bwrap nil t nil "--ro-bind" "/" " > (unwind-protect (progn (let ((status (call-process bwrap nil t nil " > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current > (progn (set-file-modes input-file 256) (set-file-modes output-file 1 > (unwind-protect (progn (set-file-modes input-file 256) (set-file-mod > (let* ((input-file (expand-file-name "test.el" directory)) (output-f > (progn (let* ((input-file (expand-file-name "test.el" directory)) (o > (unwind-protect (progn (let* ((input-file (expand-file-name "test.el > (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct > (let ((bwrap (executable-find "bwrap")) (emacs (expand-file-name inv > (closure (t) nil (let ((bwrap (executable-find "bwrap")) (emacs (exp > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name bytecomp-tests--dest-mountpoint :docu > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co > ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) > ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/bytecomp- > command-line() > normal-top-level() > Test bytecomp-tests--dest-mountpoint condition: > (ert-test-failed > ((status . 1) > (output . > ">>Error occurred processing /tmp/emacs-test-BIdKcv-bytecomp/test.el: error ((\"file has no `lexical-binding' directive on its first line\"))\n"))) > FAILED 16/99 bytecomp-tests--dest-mountpoint (0.056259 sec) at lisp/emacs-lisp/bytecomp-tests.el:1681 > ------------------------- snip -------------------------