From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 02:04:55 +0300 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18781"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , monnier@iro.umontreal.ca, "emacs-devel@gnu.org" To: Daniel Mendler , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 01:07:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llJfg-0004k9-Fu for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 01:07:40 +0200 Original-Received: from localhost ([::1]:44982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llJff-0004vK-JI for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 19:07:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llJd8-00034u-1l for emacs-devel@gnu.org; Mon, 24 May 2021 19:05:02 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:36398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llJd6-0003BK-Gq for emacs-devel@gnu.org; Mon, 24 May 2021 19:05:01 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id n4so4190879wrw.3 for ; Mon, 24 May 2021 16:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nrigmag4NK7bJGx7bRtTBhqB3hNrIoJcJDhMhKbVFkg=; b=fNxmRanxjh7Tc+Qo4CZpVgc95AyHRkvEwj5u34BIc+4OTFh1fOJ3g3Qmz0pF8PK16e DPtEp+67fZ7l/19j3/bgtsZmddF22/XuMJjAOlx/4JbU5Naa4x76neJkEYABKczhoBEe DnwFi13Pys1fau474rW1c+ERXs3C12a+00Ofleav9Z2MGDdhSBxnX63OnimMTOSmA8bp r88O9lvTsG5TnbqoI0p++sfri88UFB2t1AaGXq3gA0WVjiwKsHbJLDFeBGTSutkbvX87 sRT5p0jEFBaKMQ5VqyjxWMwGpkYLi/9p0/5v0TOj4F/G7bzedaQAB+u2OCDg2FYIV7hl 40yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nrigmag4NK7bJGx7bRtTBhqB3hNrIoJcJDhMhKbVFkg=; b=sj10MtoKmZHzZCB7FR5imJ+Ac13eDFE1hhuprzNPi53V7A9eQKoekYqRoAMhANJ5gU 4YpR7kQ8L2gMEpq4kw5xkC++FkvSMMRxZJhnLhkLJX/szUla7h+r8O9mrQFr4AptYx82 nWQ6UBCoLxMNJxI+445+4gVhk/UY/jfMrRdjaNAZH66kG5k4HK13hqyxG8J/jeOMJAJm tuL20LA/LaCJfVW3Ay+St6ONmj8nLdddsGvynLeB7cLbNacZZbnxMIVFD/Mi7PY/ExXN tchzL43FbgS0mRJCkr+IWkD34gTiEd3SCo/8+SqGNtyTPuHFMk09+5qZUinYXggXwky0 0uLw== X-Gm-Message-State: AOAM532sauSTph3v2NWZJvfUyaWAeAL3NosptB0oAwCK1+TxBuRxWqNQ GclPKUG3ygLhSn3cWtnff7w= X-Google-Smtp-Source: ABdhPJycAVOSk2jMqf4/4PB0k62QR/2cuNlwJF/80EY+WyEauIxpPDdzp1ZD32YXnRGpDflM8V+Tlw== X-Received: by 2002:adf:f4ce:: with SMTP id h14mr24469711wrp.269.1621897497417; Mon, 24 May 2021 16:04:57 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f6sm16171630wru.72.2021.05.24.16.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 16:04:57 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=raaahh@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269822 Archived-At: On 24.05.2021 13:26, Daniel Mendler wrote: > This is more of a technical detail, but I also want to > stress the point made by Juri in the other mail, that the backend may > have to setup some "context" to compute the annotation data lazily. If > this setup can only be done once per redisplay of the currently visible > candidates, that is beneficial. IME when annotations are computed only for a limited subset of completions (as is the case now), it doesn't matter too much if they have to be computed twice, 'cause the time it takes is still negligible. But of course a frontend can set up a context itself (some hash-table inside its internals) which tracks which completions have which annotations, so it doesn't have to ask twice.