From dd3484bedb7f0207c64ed391d1d7e699741e9917 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 3 Jun 2020 18:15:54 -0700 Subject: [PATCH] Revert make-text-button string copy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * lisp/button.el (make-text-button): Don’t make a copy of a button’s string label. This reverts the change made in 2020-05-17T05:23:28Z!eggert@cs.ucla.edu, which broke SLY. Problem reported by João Távora in: https://lists.gnu.org/r/emacs-devel/2020-06/msg00117.html However, we’ll need a better fix for this once string literals become contents, if SLY uses string constants for text button labels. --- lisp/button.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/button.el b/lisp/button.el index a91b0482ac..3a6a6de774 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -349,7 +349,6 @@ make-text-button (or (plist-member properties 'type) (plist-member properties :type)))) (when (stringp beg) - (setq beg (copy-sequence beg)) ;; In case BEG is not mutable. (setq object beg beg 0 end (length object))) ;; Disallow setting the `category' property directly. (when (plist-get properties 'category) -- 2.25.4