From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Fri, 7 Jan 2022 11:36:07 +0100 Message-ID: References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> <86v8z26o15.fsf@mail.linkov.net> <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> <86y23xuv8g.fsf@mail.linkov.net> <867dbgtuls.fsf@mail.linkov.net> <7402a9b1-91cf-a14e-32dc-e9a0cd27dd82@gmx.at> <86lezs4pmt.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18009"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , sdsg@amazon.com, emacs-devel@gnu.org, Eli Zaretskii , Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 07 11:38:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5mdS-0004PK-T5 for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 11:38:14 +0100 Original-Received: from localhost ([::1]:48270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5mdQ-0004LA-Om for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 05:38:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mbY-0002ib-Tv for emacs-devel@gnu.org; Fri, 07 Jan 2022 05:36:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:53305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mbW-0004Xo-WD; Fri, 07 Jan 2022 05:36:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641551768; bh=/nGYqCa9+Na/LlF1fGdWvtcoSS7xt4Op0DPghTQ1W0o=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=W8wPx3DlZ6U2q3u7Dd8XyIQS1wdoVm6HC63Pv7M3MVzobOFfkSAshs0ef/TuJbSuy rXiuK/Am4PRAb9umno/8ftpIXbJDBIqeuA2/+FI9nooPRvHvlK/WlMtntCeU39TzCB DQ5WrBbAwZGWRyxXOf4B5JOfwVtAxcojjDZ7mZwQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.103] ([212.95.5.178]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFbW0-1n9eUQ1c2o-00H4lK; Fri, 07 Jan 2022 11:36:08 +0100 In-Reply-To: <86lezs4pmt.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:2YzDK6OjaiFggGKoFZdUkU0ynwB/SveZyxgYyIn3k9qfXhHP2Fl iQ/Xe1o6btxA59ICO82e8UHMwpGR/ykUsuYwUAx0+LHfpZNtCskkl75H7kb78ZbrAoELIRt X6SNP3AKcWcC6wB576cwdwU6p3RGUzIk1zKnei5MlOreIETp5f7ZUJRaK8L6ycVtCD6Uiip aOhLPnOTUUraLz1EstTHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:2TOeWexUbxA=:VRrAClct6+zKf3l5jXYMS8 s3IrJWmF2ZXSvbcLEUSSOcF+Sl1a4XVccPhekPjKp2QlvP+VJSNJUskDdkhHvMu3qbTiUnbRN xOmO5TpqKUZ/6h7YHadDVA4wIz23e98v76ZUXZmP+KZjlNt098P2rMJuK1UTTVYRPsSrSkCSV N1ZplpVUiYuxccoKEhBTGhQkTK8Y7Ies+UUYlc1IBDFmkYnfjDUn+jS4UZbVev7KPrLGESvHk tQZdrISOPQJuIq7yrC+KaEa5D3TXDLWoX26CW6LftSCS3J+ecMUGnh6flU2BN+DapnrvazT9F S2Ne5OXe0xj4VcP24Asqu3lHrcyNq6yp0uDbWcIlnOnJO/vFXGannXkk9vx/y1slWpwf7Sbxb erbms+FryqJ1FZLzR/IW0pRGEANeLoTxCPFdc+z/UwDeHLMGhxnDAwiNXBV69/2fPamZCNtYC mz1HJcBrYbyIG/g/RVnUfyL7N8gQlbx2PrabTrmzHiPH8Zr4u6x8RVKfig4PIlqj2+rUeTs8+ wGVyMueiVo9RHL7SrGmFQSUV++S643ywKSxqji5ZT8g2kdqRz1P1iKRUkcVSZfYYBPPRv6LU6 lWigxN5wpDaRU8eSoqKl0WE9oNK9vMioIwOiTLVQ73NIeZ6B+Z9GzEM1vZXxTOEjEq5eOblxp xAJdAL+kxE6nU5pab/vZ0H4b6CavQrKHtnLmgYjgEePzAqTnZMf2gD7Led8TlIWfDKoyp2D0e 492qziMtlfda2QMBP3qVEM7GRyWKbLB0Q1wDUh194SqfE/646e6S5kQG1h9J9cFe9BZ3MjoT Received-SPF: pass client-ip=212.227.15.19; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284402 Archived-At: > So in addition to > > (pop-to-buffer "*shell*" '(nil . ((label . *shell*)))) > > it will also allow > > (pop-to-buffer "*shell*" nil nil '*shell*) > > and > > (pop-to-buffer-same-window "*shell*" nil '*shell*) > > ? Yes. Looks neither pretty nor intuitive. Note that a 'pop-to-buffer' call can add an arbitrary element like a label to the action alist and 'display-buffer-alist' can, via a function, interpret that label in any which way. So we do not have to add anything new to make such things work. The important aspects are rather discoverability and ease of documentation. > For consistency with 'pop-to-buffer-same-window', shouldn't then > new 'display-comint-buffer-action' have a similar function: > > (defun pop-to-comint-buffer (buffer &optional norecord) > (pop-to-buffer buffer display-comint-buffer-action norecord)) We could do that. But let's fix the customization type of 'display-comint-buffer-action' first. martin