From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>, Emacs discussions <emacs-devel@gnu.org>
Subject: Re: html, css, and js modes working together
Date: Mon, 6 Feb 2017 05:08:05 +0200 [thread overview]
Message-ID: <e0514b19-7953-bc07-d9ed-d5152ced94e9@yandex.ru> (raw)
In-Reply-To: <87o9ynarz3.fsf@tromey.com>
Hi Tom,
On 31.01.2017 22:34, Tom Tromey wrote:
> I tried to send this last night but it bounced for some reason.
>
> This patch changes the html, css, and js modes to work together a bit.
> With this, the contents of a <style> element are syntax-highlighted and
> indented according to css-mode rules, and the contents of a <script>
> element are syntax-highlighted and indented according to js-mode rules.
> I'd appreciate comments on this approach.
I'm glad you are interested in the problem of mixed modes, but
implementing it inside html-mode is likely to make life more difficult
for the existing mixed-mode frameworks because now html-mode's
indentation code and font-lock rules are that much more complex.
So this is great as an experiment, and maybe a direction toward creating
a built-in mixed-mode solution, but why not call the result
html-and-stuff-mode in the meantime?
One might argue that we wouldn't need mmm-mode for the HTML-CSS-and-JS
combination, but even aside from backward compatibility considerations,
the third-party frameworks will continue to be useful for the edge cases
they handle, such as solving some of the problems you mentioned in your
next-to-last item.
> * I used the existing (but apparently unused) prog-indentation-context
> variable in this.
So far it's only used in python-mode, I think.
> I was initially skeptical of using a global
> variable but it did turn out to be pretty handy for SMIE.
A global variable is usually easy to use, if you remember to do so. I'd
like to replace it with a different indent-line-function variable and
calling convention, but that's a separate discussion.
> * This work doesn't address the need for per-region font locking at all.
Not sure what you mean by that. But I've applied the patch, and I don't
see any JS or CSS specific highlighting. Indentation kinda works, though.
Couple more things to think about:
- Both css-mode and js-mode call syntax-ppss in their indentation code.
Luckily, their syntax tables are fairly compatible. But
sgml-syntax-propertize-rules calls syntax-ppss as well.
That might lead to some problems with the cache. Maybe it's not a
problem as long as () and {} have the same syntax classes in html-mode.
- Try this example:
<html>
<script>
var a = 4;
alert(a);
</script>
</html>
It indents fine. Now try replacing "4" with "4 < 5" and reindenting the
"alert" line. It jumps to the right.
next prev parent reply other threads:[~2017-02-06 3:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 20:34 html, css, and js modes working together Tom Tromey
2017-02-01 7:29 ` Clément Pit-Claudel
2017-02-07 4:33 ` Tom Tromey
2017-02-10 2:31 ` Tom Tromey
2017-02-02 14:19 ` Stefan Monnier
[not found] ` <87mvdy7f2g.fsf@tromey.com>
2017-02-07 14:33 ` Stefan Monnier
2017-02-06 3:08 ` Dmitry Gutov [this message]
2017-02-06 3:26 ` Tom Tromey
2017-02-06 3:46 ` Dmitry Gutov
2017-02-06 6:50 ` Clément Pit-Claudel
2017-02-06 14:17 ` Stefan Monnier
2017-02-06 20:25 ` Tom Tromey
2017-02-06 20:58 ` Dmitry Gutov
2017-02-06 22:42 ` Stefan Monnier
2017-02-06 23:51 ` Lennart Borgman
2017-02-07 3:40 ` Tom Tromey
2017-02-07 11:28 ` Dmitry Gutov
2017-02-09 23:45 ` Tom Tromey
2017-02-10 20:05 ` Stefan Monnier
2017-02-10 21:15 ` Tom Tromey
2017-02-10 23:45 ` Stefan Monnier
2017-02-11 17:46 ` Tom Tromey
2017-02-11 20:20 ` Stefan Monnier
2017-02-12 16:17 ` Dmitry Gutov
2017-02-12 16:20 ` Dmitry Gutov
2017-02-12 16:52 ` Tom Tromey
2017-02-13 1:12 ` Dmitry Gutov
2017-02-13 1:59 ` Dmitry Gutov
2017-02-13 2:48 ` Tom Tromey
2017-02-14 1:34 ` Dmitry Gutov
2017-03-19 17:30 ` Tom Tromey
2017-03-21 9:15 ` Dmitry Gutov
2017-03-24 3:18 ` Tom Tromey
2017-03-24 12:02 ` Stefan Monnier
2017-03-24 12:08 ` Toon Claes
2017-03-24 12:59 ` Noam Postavsky
2017-03-24 14:17 ` Tom Tromey
2017-04-05 22:01 ` Tom Tromey
2017-04-06 2:28 ` Leo Liu
2017-04-06 14:12 ` Dmitry Gutov
2017-02-11 17:39 ` Tom Tromey
2017-02-11 19:48 ` Stefan Monnier
2017-02-12 3:49 ` Tom Tromey
2017-02-12 5:26 ` Stefan Monnier
2017-02-12 6:14 ` Tom Tromey
2017-02-12 7:02 ` Stefan Monnier
2017-02-12 7:22 ` Tom Tromey
2017-02-12 11:14 ` martin rudalics
2017-02-12 16:01 ` Eli Zaretskii
2017-02-12 16:32 ` Tom Tromey
2017-02-12 17:14 ` Stefan Monnier
2017-02-12 17:36 ` Tom Tromey
2017-02-12 18:17 ` Eli Zaretskii
2017-02-12 16:59 ` Stefan Monnier
2017-02-11 0:28 ` Please ack Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0514b19-7953-bc07-d9ed-d5152ced94e9@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).