From: Lennart Borgman <lennart.borgman@gmail.com>
To: Ken Brown <kbrown@cornell.edu>
Cc: Chong Yidong <cyd@stupidchicken.com>,
Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Cygwin patches
Date: Mon, 23 Nov 2009 00:30:14 +0100 [thread overview]
Message-ID: <e01d8a50911221530g552fd8d4xc41f6efb417b91fc@mail.gmail.com> (raw)
In-Reply-To: <4B09C807.8000202@cornell.edu>
On Mon, Nov 23, 2009 at 12:23 AM, Ken Brown <kbrown@cornell.edu> wrote:
> On 11/22/2009 6:03 PM, Chong Yidong wrote:
>>
>> Ken Brown <kbrown@cornell.edu> writes:
>>
>>> Thanks for the suggestion. My revised patch is attached. If it looks
>>> OK, could someone please check it in?
>>
>> Your patch looks incorrect. It's not your job to add the "file://"
>> part; that's done in the rest of the function. Does this corrected
>> patch do the right thing on cygwin?
>
> Yes, it does do the right thing on cygwin. As I said earlier in the thread,
> the rest of the function *doesn't* add "file://"; it adds "file:" without
> the slashes. But if I add "file://", the rest of the function leaves this
> alone. I guess browse-url-filename-alist would have to be changed to make
> it correctly add "file://" in this situation, but I haven't tried to dig
> into it to figure out how it works. It seemed easier (and harmless) to just
> add it myself.
We were recently discussing if it should be file: or file:/// for w32.
I really do not know which is best but I suspect file:/// have a
slightly better chance to work. I just saw an instance
(css-validator.jar with Rhino) where it worked better.
next prev parent reply other threads:[~2009-11-22 23:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 20:00 Cygwin patches Ken Brown
2009-11-20 21:50 ` Chong Yidong
2009-11-20 21:59 ` Lennart Borgman
2009-11-20 22:26 ` Ken Brown
2009-11-20 23:54 ` Lennart Borgman
2009-11-21 8:12 ` Eli Zaretskii
2009-11-21 12:12 ` Ken Brown
2009-11-21 12:16 ` Lennart Borgman
2009-11-21 12:42 ` Eli Zaretskii
2009-11-21 21:21 ` Ken Brown
2009-11-21 21:48 ` Eli Zaretskii
2009-11-22 5:25 ` Davis Herring
2009-11-22 12:59 ` Ken Brown
2009-11-22 23:03 ` Chong Yidong
2009-11-22 23:23 ` Ken Brown
2009-11-22 23:30 ` Lennart Borgman [this message]
2009-11-23 1:37 ` Ken Brown
2009-11-23 1:42 ` Lennart Borgman
2009-11-23 1:50 ` Chong Yidong
2009-11-23 2:09 ` Ken Brown
2009-11-23 19:50 ` Ken Brown
2009-11-23 20:59 ` Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2009-11-20 23:40 Angelo Graziosi
2009-11-21 4:50 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01d8a50911221530g552fd8d4xc41f6efb417b91fc@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).