From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Cygwin patches Date: Sat, 21 Nov 2009 13:16:03 +0100 Message-ID: References: <4B06F562.8060504@cornell.edu> <871vjs7tn4.fsf@stupidchicken.com> <4B071784.5030901@cornell.edu> <83my2gpa83.fsf@gnu.org> <4B07D914.8070608@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1258805811 23018 80.91.229.12 (21 Nov 2009 12:16:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2009 12:16:51 +0000 (UTC) Cc: Eli Zaretskii , cyd@stupidchicken.com, emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 21 13:16:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBotP-0006ww-HX for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 13:16:44 +0100 Original-Received: from localhost ([127.0.0.1]:35072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBotO-0001wl-V6 for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 07:16:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBotJ-0001vU-Qg for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:16:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBotF-0001oz-FR for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:16:37 -0500 Original-Received: from [199.232.76.173] (port=52999 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBotF-0001oj-2h for emacs-devel@gnu.org; Sat, 21 Nov 2009 07:16:33 -0500 Original-Received: from mail-yx0-f191.google.com ([209.85.210.191]:62843) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBotB-0002YH-OZ; Sat, 21 Nov 2009 07:16:30 -0500 Original-Received: by yxe29 with SMTP id 29so10349264yxe.14 for ; Sat, 21 Nov 2009 04:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=3N8QR9NtvWng3iJ6an4lYLa5t1+wr7hWLh70W6+fyCU=; b=la3c+PDjecmq4zxE9mRdLXnXppZ6nS0GHdUfDd7EVWn4JUdq7JU1eHnEcL7wS7NUmY k6xWb1bZ0KLeFo88N/Ypgx800lV6Kwl3Z4btclL8FjY7bBAPB8p8IVqN4/Nw5GvKFItY OfmwOycJ59r+IlUBixr8uUwnJ0QMCMu0mXo9Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=vtMlrjNY8jZJ9FWYkDSEWcOjIQJIv1eGQfOaHFcyRO6lxFQpg6Rv/vtFN9QhGg9kA0 5fIkHB0VUws4N5TlkLpGJ+FzWm/VZzMLGZORX48l+eiCIhVvb8YnA3gb4kw7kSEV9NbM TGJAPZZujc285jAFNkDM+hwUfg5CSnuGUXYco= Original-Received: by 10.100.56.12 with SMTP id e12mr3121658ana.162.1258805783057; Sat, 21 Nov 2009 04:16:23 -0800 (PST) In-Reply-To: <4B07D914.8070608@cornell.edu> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117435 Archived-At: On Sat, Nov 21, 2009 at 1:12 PM, Ken Brown wrote: >> >> I think that the right fix would be in browse-url-file-url, so that it >> does return a correctly converted URL. =C2=A0Using cygstart directly in >> browse-url-of-file deviates too much from what other platforms do -- >> they all invoke the browser in browse-url. =C2=A0Such a deviation could >> mean maintenance headaches in the future. =C2=A0For example, browse-url >> takes care of setting the environment for the process being invoked, >> while your patch short-circuits that for Cygwin. > > OK, that makes sense. =C2=A0I'll figure out how to patch browse-url-file-= url > instead. =C2=A0But it will still mean cygwin-specific code in that functi= on. =C2=A0Is > that acceptable? > > [BTW, Lennart's suggestion that the cygwin-specific code should be moved = to > browse-url doesn't work. =C2=A0In fact, browse-url works fine on cygwin a= s is; it > just needs to be given a good URL.] Sorry for the confusion. I meant the same as Eli here.