From: Lennart Borgman <lennart.borgman@gmail.com>
To: "Stephen J. Turnbull" <stephen@xemacs.org>
Cc: Xavier Maillard <xma@gnu.org>, emacs-devel@gnu.org
Subject: Re: Science to suppress compiler warnings
Date: Wed, 3 Jun 2009 11:58:55 +0200 [thread overview]
Message-ID: <e01d8a50906030258p65110910pd43603ec908225d0@mail.gmail.com> (raw)
In-Reply-To: <87zlcqgc5p.fsf@uwakimon.sk.tsukuba.ac.jp>
On Wed, Jun 3, 2009 at 6:43 AM, Stephen J. Turnbull <stephen@xemacs.org> wrote:
> Xavier Maillard writes:
>
> > Elisp manual at "Compiler Errors" section (16.6) says we should
> > conditionalize variable use with a boundp test (same thing for
> > undefined function) but I find it very unpractical.
>
> If this is related to your work on supporting old versions of Emacs,
> my advice is "live with it". Either use the runtime test if it's an
> Emacs-defined variable, or use an appropriate `defvar' or `defconst'
> to initialize the variable.
>
> Suppressing compiler warnings is very likely to lead to runtime
> errors, often intermittent ones. Eg, there may be an unusual code
> path that leads to reference to a void variable very early in an Emacs
> session. Boom! But unless you type that exact sequence of commands
> immediately after starting Emacs, something requires the relevant
> library, and no problem can be found.
>
> Such bugs are quite hard to diagnose, even to localize, if the user is
> not an Emacs expert. A boundp check with a good error message, or a
> proper initialization with `defvar', will prevent or at least help
> diagnose a lot of problems.
But if you combine (defvar foo) with tests everywhere foo is used you
should be safe ...
prev parent reply other threads:[~2009-06-03 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 23:08 Science to suppress compiler warnings Xavier Maillard
2009-06-02 23:36 ` Davis Herring
2009-06-03 8:58 ` Xavier Maillard
2009-06-02 23:57 ` Drew Adams
2009-06-03 0:51 ` Lennart Borgman
2009-06-03 5:35 ` Stefan Monnier
2009-06-03 9:04 ` Xavier Maillard
2009-06-03 17:33 ` Stefan Monnier
2009-06-03 14:11 ` Drew Adams
2009-06-03 8:40 ` Andreas Schwab
2009-06-03 12:26 ` Xavier Maillard
2009-06-03 8:59 ` Xavier Maillard
2009-06-03 4:43 ` Stephen J. Turnbull
2009-06-03 9:58 ` Lennart Borgman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01d8a50906030258p65110910pd43603ec908225d0@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=stephen@xemacs.org \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).