From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: other-window-or-frame Date: Wed, 01 Feb 2006 12:13:34 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1138833973 7516 80.91.229.2 (1 Feb 2006 22:46:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Feb 2006 22:46:13 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 01 23:46:12 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F4Qh2-0001OU-TP for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2006 23:43:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F4Qk7-0004Si-Ir for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2006 17:46:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F4OiB-0007Us-GR for emacs-devel@gnu.org; Wed, 01 Feb 2006 15:36:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F4OHa-00058n-T9 for emacs-devel@gnu.org; Wed, 01 Feb 2006 15:08:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F4NUQ-00008D-PN for emacs-devel@gnu.org; Wed, 01 Feb 2006 14:18:03 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1F4NT8-0006Qr-1Q for emacs-devel@gnu.org; Wed, 01 Feb 2006 14:16:42 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1F4NR3-0001tN-OX for emacs-devel@gnu.org; Wed, 01 Feb 2006 20:14:34 +0100 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Feb 2006 20:14:33 +0100 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Feb 2006 20:14:33 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 57 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49888 Archived-At: Kevin Rodgers wrote: > Drew Adams wrote: >> If a frame is `one-window-p', command `other-window' silently does >> nothing. >> It might be better to let it do `other-frame' in that case. The optional >> second arg to `other-window' is not accessible interactively anyway, >> so what >> about this: >> >> 1. Bind a new command to `C-x o', to replace `other-window'. It would >> do the >> same thing except when `one-window-p' - in that case, it would do >> `other-frame'. >> >> 2. Keep function `other-window' as is (with its second arg), for Lisp. >> >> IOW (but with a better doc string): >> >> (defun other-window-or-frame (arg) >> "`other-frame', if `one-window-p'; otherwise, `other-window'." >> (interactive "p") >> (if (one-window-p) (other-frame arg) (other-window arg))) >> >> (define-key ctl-x-map "o" 'other-window-or-frame) > > Actually, now that you mention it, I've just added this to my .emacs: > > (defadvice other-window (before one-window-p activate) > "If there are no other windows, signal an error." > (when (one-window-p) > (error "No other windows"))) > > (defadvice other-frame (before one-frame-p activate) > "If there are no other frames, signal an error." > (when (= (length (frame-list)) 1) > (error "No other frames"))) Just to follow up: Experience proved that to be completely unsatisfactory since the advice affects all calls to those functions. This is better: (defadvice other-window (before one-window-p activate) "When called interactively, signal an error if there are no other windows." (when (and (interactive-p) (one-window-p)) (error "No other windows"))) (defadvice other-frame (before one-frame-p activate) "When called interactively, signal an error if there are no other frames." (when (and (interactive-p) (= (length (frame-list)) 1)) (error "No other frames"))) > (setq debug-ignored-errors > (cons "\\`No other \\(window\\|frame\\)s\\'" debug-ignored-errors)) -- Kevin Rodgers