From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: [drew.adams@oracle.com: links in Help buffer aren't always correct] Date: Tue, 13 Dec 2005 10:17:36 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1134497754 24680 80.91.229.2 (13 Dec 2005 18:15:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2005 18:15:54 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 19:15:53 2005 Return-path: Original-Received: from [199.232.75.2] (helo=lists.gnu.org) by ciao.gmane.org with esmtp (Exim 4.43) id 1EmEeP-0004dj-RK for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2005 19:13:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EmEey-0004XO-3T for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2005 13:13:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EmDsp-0002KP-5J for emacs-devel@gnu.org; Tue, 13 Dec 2005 12:24:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EmDsm-0002Gh-6Z for emacs-devel@gnu.org; Tue, 13 Dec 2005 12:24:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EmDsl-0002GR-Ts for emacs-devel@gnu.org; Tue, 13 Dec 2005 12:24:08 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EmDuh-00089M-EZ for emacs-devel@gnu.org; Tue, 13 Dec 2005 12:26:07 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EmDpI-0003EK-LU for emacs-devel@gnu.org; Tue, 13 Dec 2005 18:20:32 +0100 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 13 Dec 2005 18:20:32 +0100 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 13 Dec 2005 18:20:32 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 66 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-Broken-Reverse-DNS: no host name found for IP address 199.232.75.2 Xref: news.gmane.org gmane.emacs.devel:47626 Archived-At: Richard Stallman wrote: > Would someone please DTRT about this, then ack? > > ------- Start of forwarded message ------- > From: "Drew Adams" > To: "Emacs-Pretest-Bug" > Date: Mon, 28 Nov 2005 08:58:08 -0800 > X-Brightmail-Tracker: AAAAAQAAAAI= > X-Whitelist: TRUE > Subject: links in Help buffer aren't always correct > Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org > X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on monty-python > X-Spam-Level: > X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63 > > For example, C-h f buffer-list shows this text: > > buffer-list is a built-in function in `C source code'. > (buffer-list &optional frame) > > Return a list of all existing live buffers. > If the optional arg frame is a frame, we return the buffer list > in the proper order for that frame: the buffers in frame's `buffer-list' > frame parameter come first, followed by the rest of the buffers. I think it would be better to say: the buffers in FRAME's `buffer-list' frame parameter come first, or: the buffers in the frame's `buffer-list' frame parameter come first, or: the buffers in its `buffer-list' frame parameter come first, > [back] > > The text "buffer-list" in the last sentence is linked to the help for the > `buffer-list' function, not the `buffer-list' frame parameter. Either there > should be no link here (if there is no way to show help on the parameter) or > the link should point to help on the frame parameter. Since there is no describe-frame-parameter command, and the phrase "frame paramter" follows the quoted symbol (unlike the phrases listed in help-xref-symbol-regexp, which precede quoted symbols), we can avoid hyperlinking such phrases by changing help-make-xrefs in help-mode.el from: ;; Quoted symbols (save-excursion (while (re-search-forward help-xref-symbol-regexp nil t) (let* ((data (match-string 8)) (sym (intern-soft data))) (if sym to: ;; Quoted symbols (save-excursion (while (re-search-forward help-xref-symbol-regexp nil t) (let* ((data (match-string 8)) (sym (intern-soft data))) (if (and sym (save-match-data (not (looking-at "[ \t\n]+frame parameter")))) -- Kevin Rodgers