From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: image size limit? Date: Tue, 11 Oct 2005 15:19:50 -0600 Message-ID: References: <87oe5v7q19.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1129065969 25745 80.91.229.2 (11 Oct 2005 21:26:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2005 21:26:09 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 11 23:26:07 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EPRbu-00049S-54 for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 23:24:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPRbt-0007Qb-Id for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 17:24:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EPRbl-0007QM-KS for emacs-devel@gnu.org; Tue, 11 Oct 2005 17:24:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EPRbk-0007QA-3v for emacs-devel@gnu.org; Tue, 11 Oct 2005 17:24:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPRbj-0007Q7-OH for emacs-devel@gnu.org; Tue, 11 Oct 2005 17:24:24 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EPRbj-0004gU-Hq for emacs-devel@gnu.org; Tue, 11 Oct 2005 17:24:23 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EPRZ6-0003GU-Ap for emacs-devel@gnu.org; Tue, 11 Oct 2005 23:21:40 +0200 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Oct 2005 23:21:40 +0200 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Oct 2005 23:21:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 17 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: <87oe5v7q19.fsf@stupidchicken.com> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43891 Archived-At: Chong Yidong wrote: > One place where we can set a limit is in x_create_x_image_and_pixmap, > where we malloc a pixmap to store the image contents. The data > supplied to us by the external library is copied into this pixmap. We > could signal an error if width and height are too large. However, > this seems like closing the barn door after the horses have left -- > the external library will already have allocated a big chunk of > memory. But freeing that memory immediately (if the library provides such a function) and signalling the error would certainly be better than allocating the memory for the pixmap and proceeding to display the image. It's more like closing the barn door after half of the horses have left. -- Kevin Rodgers