From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Mon, 05 Apr 2021 23:09:23 +0000 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 01:10:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYMo-0006SD-Im for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 01:10:46 +0200 Original-Received: from localhost ([::1]:49504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTYMn-0005S2-KB for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 19:10:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTYLY-00050S-Hu for emacs-devel@gnu.org; Mon, 05 Apr 2021 19:09:28 -0400 Original-Received: from heytings.org ([95.142.160.155]:58382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTYLW-0002CL-JW for emacs-devel@gnu.org; Mon, 05 Apr 2021 19:09:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617664164; bh=2OjxWJOnFuWM3O6T7w9dgWOjZK+Ot7/VTX8jtZOBWjU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=QN5Okv7ZjroaEXjOKyhSQJP7mTmAu4reYuooFeBdBPtHBUDk0lw0DNzZq+VfKzZHD d7IJoa62tgfZkkamH/CLdT6/meLq77a28t5pGUY5XjRqmcrcvipZANOj6AIfUSgXc1 bqzuXAwYtKCODxa4XB/di1Oiw1R7LR+XrZ56cL6y2Thap040BWwbNKymIU1h6t9wmY PUsTFyyqM7D6wTKsJWP1m9I2E8bRX6shtOk/npp9TU9U8weo9Att7/oCUy3uAVIl1B ozxtgelI51wB1SsT7Nbv0tQGIpk0zxmTw1I3r+wthrSB3bjotQTCn48UmVovbXO7VB ikhSyJz+xJ6BA== In-Reply-To: <87h7kkwcy1.fsf@posteo.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267448 Archived-At: > > Why is this a patch that uses advice and hook instead of a user option > that changes the behaviour of icomplete directly? > Because it's the simplest / cleanest way to do it. It's a kind of derived minor mode.