From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Date: Thu, 29 Apr 2021 19:16:07 +0200 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <9de0a112-9e68-d645-451e-084a3c7c6725@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Stefan Monnier , "emacs-devel@gnu.org" To: Dmitry Gutov , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 19:23:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcANj-00040m-Bm for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 19:23:19 +0200 Original-Received: from localhost ([::1]:54222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcANi-0006mI-EE for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 13:23:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcAGr-0002jj-4I for emacs-devel@gnu.org; Thu, 29 Apr 2021 13:16:14 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:44455 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcAGo-0002cm-KO for emacs-devel@gnu.org; Thu, 29 Apr 2021 13:16:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9mSzkrIXvu2dNKiIlbHTBWA3n66uG6ian/fxfef1mxc=; b=J0lexHY6Hs7MY2yQX0gad2QrrS 702exUS92TlZ6mzOx6KAwpelrG/0SinhO1tN1kvQ5hzP+GvXnhR+vs9/POLr14o+IgCek/AjaDSUV yjXGMRxofJZfXNRBuj1cIDFeiiZltf7UI5BlumcyWbyQzqYSfBJJ5zn1Onji/ORmwk44=; In-Reply-To: <9de0a112-9e68-d645-451e-084a3c7c6725@yandex.ru> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268624 Archived-At: On 4/29/21 7:09 PM, Dmitry Gutov wrote: > If affixation-function didn't return a three-element list (and instead > only returned some focused information pertaining to a single value), > you wouldn't have this problem. I don't understand the argument here. From my perspective the `affixation-function` is good as is. It is a generalization of the `annotation-function` which allows transformation of all candidates at once and it additionally allows prefixes. However one could discuss if the affixation function should be allowed to transform the actual candidate string, as has been mentioned in the discussion before. I think one can set text properties but one is not allowed to change the candidate string - this will break `choose-completion`. Daniel