unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: "Yuri Khan" <yuri.v.khan@gmail.com>,
	"Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: RE: Why does show_help_echo call substitute_command_keys?
Date: Fri, 21 Jul 2017 07:54:56 -0700 (PDT)	[thread overview]
Message-ID: <df88c67c-26bc-4ce1-ab72-8f667e573f48@default> (raw)
In-Reply-To: <CAP_d_8VLTwcWdtCdU62FHOBkHZKe6uc-izoV01H9cJ8TwyO+Cw@mail.gmail.com>

> > Ok. So we don't expect callers to explicitly use substitute-command-keys
> on their help-echo properties?
> 
> Imagine if it were so.
> 
> You add a button to the tool bar, with a help-echo property containing
> tooltip text with command keys substituted at the time of addition.
> 
> The user rebinds the command to another key. Your button retains its
> (now inaccurate) tooltip text.

Which just means that your code isn't good enough.

If you hard-code a `help-echo' property to ANYTHING and some
later changes make that value no longer appropriate...



  parent reply	other threads:[~2017-07-21 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 17:05 Why does show_help_echo call substitute_command_keys? Clément Pit-Claudel
2017-07-21  8:48 ` Yuri Khan
2017-07-21  9:01   ` Clément Pit-Claudel
2017-07-21  9:10     ` Yuri Khan
2017-07-21  9:19       ` Clément Pit-Claudel
2017-07-21 13:43         ` Stefan Monnier
2017-07-21 14:54           ` Drew Adams
2017-07-21 14:54       ` Drew Adams [this message]
2017-07-21 14:54     ` Drew Adams
2017-07-21 14:54   ` Drew Adams
2017-07-21 17:49     ` Yuri Khan
2017-07-21 17:54       ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df88c67c-26bc-4ce1-ab72-8f667e573f48@default \
    --to=drew.adams@oracle.com \
    --cc=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).