From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Errors indicated by ineffective backslashes in string literals
Date: Sat, 16 Mar 2019 11:40:23 -0700 [thread overview]
Message-ID: <df8602f5-c15d-b15e-2df3-18ffcc2689df@cs.ucla.edu> (raw)
In-Reply-To: <D2E71D4B-FBCE-42BA-B937-DF5350DF7C8C@acm.org>
[-- Attachment #1: Type: text/plain, Size: 110 bytes --]
I installed that in your name, along with the attached extra glitch-fix. Thanks
for doing all this checking!
[-- Attachment #2: 0001-Fix-regexp-typo-in-vc-git-program-version.patch --]
[-- Type: text/x-patch, Size: 1038 bytes --]
From dfa0bb35a546367dc1cbcde15fc2acbbc92712bc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 16 Mar 2019 11:38:36 -0700
Subject: [PATCH] Fix regexp typo in vc-git--program-version
* lisp/vc/vc-git.el (vc-git--program-version):
Require a period after ".windows", instead of allowing any char.
---
lisp/vc/vc-git.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index c990b0659d..6b8ed7e2c1 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -253,7 +253,7 @@ vc-git--program-version
;; Git for Windows appends ".windows.N" to the
;; numerical version reported by Git.
(string-match
- "git version \\([0-9.]+\\)\\(\\.windows.[0-9]+\\)?$"
+ "git version \\([0-9.]+\\)\\(\\.windows\\.[0-9]+\\)?$"
version-string))
(match-string 1 version-string)
"0")))))
--
2.17.1
next prev parent reply other threads:[~2019-03-16 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 18:09 Errors indicated by ineffective backslashes in string literals Mattias Engdegård
2019-03-16 18:25 ` Stefan Monnier
2019-03-16 19:04 ` Mattias Engdegård
2019-03-16 19:22 ` Stefan Monnier
2019-03-19 1:56 ` Paul Eggert
2019-03-16 18:40 ` Paul Eggert [this message]
2019-03-16 19:06 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df8602f5-c15d-b15e-2df3-18ffcc2689df@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).