From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: Define-key doc string - binding changes always if it exists Date: Thu, 11 Aug 2005 09:05:57 -0600 Message-ID: References: <42FA738C.9020300@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1123774016 26874 80.91.229.2 (11 Aug 2005 15:26:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 Aug 2005 15:26:56 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 11 17:26:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E3ExD-0002sd-Go for ged-emacs-devel@m.gmane.org; Thu, 11 Aug 2005 17:26:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E3F0N-0005VY-Ls for ged-emacs-devel@m.gmane.org; Thu, 11 Aug 2005 11:30:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E3Ezk-0005Kh-UL for emacs-devel@gnu.org; Thu, 11 Aug 2005 11:29:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E3Ezh-0005IN-Mo for emacs-devel@gnu.org; Thu, 11 Aug 2005 11:29:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E3Eyd-0004qP-51 for emacs-devel@gnu.org; Thu, 11 Aug 2005 11:28:15 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1E3Eur-0003UB-AP for emacs-devel@gnu.org; Thu, 11 Aug 2005 11:24:21 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1E3Een-0008Js-5Q for emacs-devel@gnu.org; Thu, 11 Aug 2005 17:07:45 +0200 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Aug 2005 17:07:45 +0200 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Aug 2005 17:07:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: <42FA738C.9020300@student.lu.se> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41920 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41920 Lennart Borgman wrote: > I found the doc string for define-key a bit strange. It kind of suggests > that if the keymap is not sparse then it is not changed. I suggest the > following patch: I don't agree. You've changed: > -If KEYMAP is a sparse keymap with a binding for KEY, the existing > -binding is altered. If there is no binding for KEY, the new pair > -binding KEY to DEF is added at the front of KEYMAP. */) to: > +If KEYMAP is a sparse keymap and there is no binding for KEY, the new > +pair binding KEY to DEF is added at the front of KEYMAP. */) The original does not say anything about full keymaps (because there is nothing to add), whereas your version doesn't say anything about a KEY that's already bound in a sparse KEYMAP. Your version is close to what's in Emacs 21, which was corrected to distinguish between a new binding and an altered binding: | If KEYMAP is a sparse keymap, the pair binding KEY to DEF is added at | the front of KEYMAP. -- Kevin Rodgers