From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch' Date: Mon, 8 May 2017 09:28:41 -0400 Message-ID: References: <20170322131610.22658.57119@vcs0.savannah.gnu.org> <20170322131611.5FF7D20E17@vcs0.savannah.gnu.org> <70055ee8-c1cb-30d2-8a0b-38637adad497@cornell.edu> <87mvbutvo6.fsf@luca> <4f1308e2-0b49-ef3e-fae7-02bdd8dc75ef@cornell.edu> <3b093156-b214-7e90-58a4-06343c1c73c8@cornell.edu> <87pofsnah1.fsf@detlef> <87lgqgmn5w.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1494250145 15218 195.159.176.226 (8 May 2017 13:29:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 May 2017 13:29:05 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Cc: Andreas Politz , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 08 15:29:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7iij-0003sU-Dn for ged-emacs-devel@m.gmane.org; Mon, 08 May 2017 15:29:01 +0200 Original-Received: from localhost ([::1]:59550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7iip-0002i7-4k for ged-emacs-devel@m.gmane.org; Mon, 08 May 2017 09:29:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7iic-0002hL-Ou for emacs-devel@gnu.org; Mon, 08 May 2017 09:29:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7iiT-0005gv-D9 for emacs-devel@gnu.org; Mon, 08 May 2017 09:28:54 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:35579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7iiT-0005gn-5g for emacs-devel@gnu.org; Mon, 08 May 2017 09:28:45 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v48DSerh028371; Mon, 8 May 2017 09:28:41 -0400 Original-Received: from [192.168.1.3] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v48DSdXi022295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 8 May 2017 09:28:40 -0400 In-Reply-To: <87lgqgmn5w.fsf@detlef> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 128.84.13.242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214691 Archived-At: On 5/1/2017 2:45 PM, Michael Albinus wrote: Hi Michael, > I've moved the `sit-for' call to `file-notify--test-read-event' by > intention, so we have just one place to change. You could do something > like > > (if (eq system-type 'cygwin) > (sit-for 0.1 'nodisp)) > > The other backends do not need them as far as I'm aware of, so do it at > your convenience. Maybe also with a comment ... I can find a sit-for time that works reliably when I repeatedly run file-notify-test02-rm-watch. But then that test still fails when it is run as part of 'make check'. My inclination at this point is to simply skip this test on Cygwin. Is that OK with you? Regards, Ken