unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Andreas Politz <politza@hochschule-trier.de>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch'
Date: Mon, 8 May 2017 09:28:41 -0400	[thread overview]
Message-ID: <ddff6e75-15ab-9753-46b8-ca86a7f683a6@cornell.edu> (raw)
In-Reply-To: <87lgqgmn5w.fsf@detlef>

On 5/1/2017 2:45 PM, Michael Albinus wrote:

Hi Michael,

> I've moved the `sit-for' call to `file-notify--test-read-event' by
> intention, so we have just one place to change. You could do something
> like
>
> (if (eq system-type 'cygwin)
>   (sit-for 0.1 'nodisp))
>
> The other backends do not need them as far as I'm aware of, so do it at
> your convenience. Maybe also with a comment ...

I can find a sit-for time that works reliably when I repeatedly run 
file-notify-test02-rm-watch.  But then that test still fails when it is 
run as part of 'make check'.

My inclination at this point is to simply skip this test on Cygwin.  Is 
that OK with you?

Regards,

Ken



  reply	other threads:[~2017-05-08 13:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170322131610.22658.57119@vcs0.savannah.gnu.org>
     [not found] ` <20170322131611.5FF7D20E17@vcs0.savannah.gnu.org>
2017-04-04 22:36   ` [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch' Ken Brown
2017-04-05  6:58     ` Michael Albinus
2017-04-05 19:24       ` Ken Brown
2017-04-05 21:02     ` Andreas Politz
2017-04-06  2:59       ` Ken Brown
2017-04-07 14:56         ` Ken Brown
2017-05-01 10:21           ` Michael Albinus
2017-05-01 18:28             ` Ken Brown
2017-05-01 18:45               ` Michael Albinus
2017-05-08 13:28                 ` Ken Brown [this message]
2017-05-08 15:30                   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddff6e75-15ab-9753-46b8-ca86a7f683a6@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=politza@hochschule-trier.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).