From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: project--completing-read-strict breaks ada-mode project completion table Date: Sun, 20 Jan 2019 01:05:46 +0300 Message-ID: References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> <4e729d1e-bb31-455f-fd44-e99ae5a6b9fa@yandex.ru> <86zhs5r9lr.fsf_-_@stephe-leake.org> <08de4d90-d678-0524-9356-f9a3515bf0c4@yandex.ru> <86a7k2rabi.fsf@stephe-leake.org> <86sgxso27d.fsf@stephe-leake.org> <86fttsntw5.fsf@stephe-leake.org> <86zhrynaaz.fsf@stephe-leake.org> <5d2000c5-0a44-4263-07d0-df462708862f@yandex.ru> <86sgxpmiad.fsf@stephe-leake.org> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ciao.gmane.org 1547935561 148012 195.159.176.228 (19 Jan 2019 22:06:01 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2019 22:06:01 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 To: Stephen Leake , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 19 23:05:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gkykZ-000cUX-1U for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 23:05:59 +0100 Original-Received: from localhost ([127.0.0.1]:60433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyki-0007bY-1I for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 17:06:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkykY-0007bN-Ms for emacs-devel@gnu.org; Sat, 19 Jan 2019 17:05:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkykX-0003cc-OX for emacs-devel@gnu.org; Sat, 19 Jan 2019 17:05:58 -0500 Original-Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:35997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkykV-0003TJ-Lw for emacs-devel@gnu.org; Sat, 19 Jan 2019 17:05:57 -0500 Original-Received: by mail-lj1-x22f.google.com with SMTP id g11-v6so14522059ljk.3 for ; Sat, 19 Jan 2019 14:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TPkzY3OsJUOf6VioHm9yU6jX0ecFq+oQVR45jaDKdX8=; b=RG6AWHa043BiIrBuFCXQub9CPIpXJQymhvJ6/q9/ckowm5iJ2buxwTQPvnnbz2bXSc X4lqqiVA5IN94AuN3f/orY1ujm1nkrzmg1Nf5MtuBivKLo1AF08GkJ7278+s/QS5qJ0u lgNlSCxj6xKMo3/+Jt/usrg2IRCfr6h+Bx/MyN8r39nnBEsbNnFa+65ilgq1IfEPuf7J hJn72ZxEBNKAn8l7PuUJh3zREsJ1mInZRxL7sTGRcTaFdAhJHNQ8e/QqIM0cvi1GCYoJ +eShHgz2EavRXeyuhrLgunS9HpBNZvHENN0riQnaf+vQd4huwQAeVCEF6h9cdXX3aMpr oIiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TPkzY3OsJUOf6VioHm9yU6jX0ecFq+oQVR45jaDKdX8=; b=FVmrT9S0LFxgg0CJMVwC51a/nDyCQaY2Sx8xAJxQOoK5IJacXyNwb2lwaSW5fMw44l ij0F+Yz1W3uJchaGd752Yyz216k57/HAZfw8BQ5nKvyIlR0y1eITsmnPxSgf+N7knA+z e8Tjc5ixzSJD16822DWEvAQbHieVGR6OLWMzqTpFnwoEXKQbupP90DMywp0fh5EwEq03 QjYWmaFpLGXJTnxx58fP+pKCDX3HqncEDu2ksvQkbdizY/gN1Pm7izvVr8quMd9Ce3nw 5vC0n1lWdIEHJIZ0wHsa3mwpQziQJHfcVaXm7eO/ZSwcBz3o6F+7D93P3S9uYaqasUVr wHXg== X-Gm-Message-State: AJcUukdZX7nB4JABlAHNHbW/EjcfikT5ALD9feiPaWmbWsnT53xdAuiA 6w3wWZ3/6MHfNpES/6jtakkktUqz X-Google-Smtp-Source: ALg8bN6GYcMKzMwV/y7HWMknPuenM3iy0o7DnlkMAMTlUqIhEMnUrPpB6ug42DhKlTZFe16aVndr6A== X-Received: by 2002:a2e:9b52:: with SMTP id o18-v6mr14600321ljj.108.1547935548406; Sat, 19 Jan 2019 14:05:48 -0800 (PST) Original-Received: from [192.168.0.108] ([79.175.3.65]) by smtp.googlemail.com with ESMTPSA id h82sm1464950lfg.94.2019.01.19.14.05.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 14:05:47 -0800 (PST) In-Reply-To: <86sgxpmiad.fsf@stephe-leake.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232507 Archived-At: On 19.01.2019 06:35, Stephen Leake wrote: >> The latency seemed to be a bit bigger than with the default completion >> table based on 'find', but not significantly so. > > Fixing the ignore would help that; it's processing all of .git. It doesn't handle the contents of .gitignore, though. That would add some performance penalty by itself. >> I don't think it can be *the* UI for everybody. > > Of course. And this is the main point; project.el must allow > users/clients to choose the completion table and completion style. Users, not necessarily backends. And let's say "completion style" in the general sense. > So the recent change to project--completing-read-strict should be > reverted, and implemented as a completion style/table instead. Please see the rest of this discussion. I think it's now the consensus that the uniquify logic should move out of the completion table. We can apply it inside project-find-file itself, depending on a user option. That will require changes in project--completing-read-strict too, of course.