From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: master 3139551: Don’t attempt to modify constant strings
Date: Sun, 17 May 2020 14:22:38 +0300 [thread overview]
Message-ID: <dc111234-6eba-6cc9-6493-b165c8ee4984@yandex.ru> (raw)
In-Reply-To: <20200517052513.C95BC20A2C@vcs0.savannah.gnu.org>
On 17.05.2020 08:25, Paul Eggert wrote:
> ;; WORKAROUND: This is nominally a constant, but the text properties
> ;; are not preserved thru dump if use defconst. See bug#21237.
> (defvar elisp--xref-format
> - (let ((str "(%s %s)"))
> - (put-text-property 1 3 'face 'font-lock-keyword-face str)
> - (put-text-property 4 6 'face 'font-lock-function-name-face str)
> - str))
> + #("(%s %s)"
> + 1 3 (face font-lock-keyword-face)
> + 4 6 (face font-lock-function-name-face)))
Seems like the comment is calling for some further changes.
next parent reply other threads:[~2020-05-17 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200517052512.20679.37725@vcs0.savannah.gnu.org>
[not found] ` <20200517052513.C95BC20A2C@vcs0.savannah.gnu.org>
2020-05-17 11:22 ` Dmitry Gutov [this message]
2020-05-17 17:01 ` master 3139551: Don’t attempt to modify constant strings Paul Eggert
2020-05-17 11:24 ` Dmitry Gutov
2020-05-17 17:10 ` Paul Eggert
2020-05-17 18:02 ` Dmitry Gutov
2020-05-17 21:36 ` Paul Eggert
2020-05-17 21:54 ` Dmitry Gutov
2020-05-17 23:16 ` Paul Eggert
2020-05-17 23:24 ` Dmitry Gutov
2020-05-18 7:03 ` Andreas Schwab
2020-05-18 22:49 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc111234-6eba-6cc9-6493-b165c8ee4984@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).