From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Fri, 21 Apr 2023 12:53:50 -0700 Message-ID: References: <838rel46ou.fsf@gnu.org> <865y9ptfa3.fsf@aarsen.me> <83354t44kn.fsf@gnu.org> <875y9p2h3u.fsf@thaodan.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32345"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Arsen_Arsenovi=c4=87?= , acm@muc.de, emacs-devel@gnu.org To: =?UTF-8?Q?Bj=c3=b6rn_Bidar?= , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 21 21:54:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppwqG-0008Hp-Vz for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Apr 2023 21:54:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppwpQ-0000rE-Sc; Fri, 21 Apr 2023 15:53:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppwpP-0000pS-8v for emacs-devel@gnu.org; Fri, 21 Apr 2023 15:53:55 -0400 Original-Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppwpN-0001Rq-Kh; Fri, 21 Apr 2023 15:53:54 -0400 Original-Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2496863c2c7so2131824a91.1; Fri, 21 Apr 2023 12:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682106832; x=1684698832; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=FY4k2kr6wDXCoZI4D6IVXEPPgSLCDH5msJ/reJ2WGL8=; b=LIivXmaI1JqwMfniezx/eH6sJZJi9QS0KX9c34ZsJFuVtiiZXOGVkXvOa+uMGc8Hpy sZ5cBPmT+loSFiyp3CK2ZSkISotlebfHIKoLTR1bWTis7a6b/Lcff1Fak7W5QAIZMraJ S0gzfJCbbsiUQuNZuj1HcUKu7oc0urbWeHd7sFls4dZ1NUDOSY1oPzTizKN8qtAR/l9E Jm0erpktzdGnQPnCT0R78jM9HZvurPUxIn3oPB8BvrZWnCjg/+RdYVnMhVJvSs9mgEKC BvcvlgIpFoXIlxs4fdZSBfKzkTgld42aIHelAX6y9tBusydRvbKCHkWahanRp/KvL7KO Lz4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682106832; x=1684698832; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FY4k2kr6wDXCoZI4D6IVXEPPgSLCDH5msJ/reJ2WGL8=; b=LSpGSHSH/uqhYI9YLr6FGVSLVtfELOFAGoNgTljiyl8XYeMunl7BR4hDkjYl5G+pKd nezSUWIkNc/KD27P+yeOdXixPF3e5muVDaXvGihJNxKAqme632SrtS6g8DjtxUocN2hu eBYV2TdXrVZsISN6IF0uhnMOf62bKeahb6r51sTrvkeIly3Hz+2UsLuwzL+T4O5184OT zkYxdQ6SWUVNTaH7S1OYVX2542LPuUNjPSpnbLjhS87uFmcFW3CycjB+d9GmvfT5l1bx JqgpkZnSS/W88JtSfIT0mnkkrvrXUgXAA0e05xhvfFjk2F/jh0H/KGZbndgblbwxKIvJ vRMg== X-Gm-Message-State: AAQBX9dyBxwMJ55lUZjr5d/uIbSUr0o1zbiNQPGcYG8hB5wpiBnrTYlH WA+zRTV2UvlPqywTxqbJ3fY= X-Google-Smtp-Source: AKy350Y3wgmlMJ4a+tfdr97uOkiYGlZ314QZQrmXitKRXhGR7EEbro6TmS5c7Ka7O6lJH3m2QOf8Qw== X-Received: by 2002:a17:90b:1643:b0:247:6be7:8cc0 with SMTP id il3-20020a17090b164300b002476be78cc0mr5649814pjb.35.1682106831732; Fri, 21 Apr 2023 12:53:51 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x15-20020a17090a46cf00b00247164c1947sm5747314pjg.0.2023.04.21.12.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 12:53:51 -0700 (PDT) Content-Language: en-US In-Reply-To: <875y9p2h3u.fsf@thaodan.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305563 Archived-At: On 4/21/2023 12:03 PM, Björn Bidar wrote: > Should branches be checked by these hooks before they are merged into > master/version branches? Before it is possible to fix any commits with > git rebase --interactive. We could ignore branches like scratch/FOO, though the easiest way to avoid errors from these hooks is just to avoid adding file entries to the commit message in the first place. The hooks only flag your commit if the message includes a file entry that's not part of the diff; it doesn't mandate that the message lists every file from the diff, however.