From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: packages submissions : org-sql-session and org-blog Date: Tue, 10 Sep 2024 22:01:42 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: pe@7d.nz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 11 05:02:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1soDcp-0000XU-6B for ged-emacs-devel@m.gmane-mx.org; Wed, 11 Sep 2024 05:02:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soDc7-00056k-Qn; Tue, 10 Sep 2024 23:01:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soDc5-00056S-GC for emacs-devel@gnu.org; Tue, 10 Sep 2024 23:01:49 -0400 Original-Received: from weasel.tulip.relay.mailchannels.net ([23.83.218.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soDc3-0005ta-U6 for emacs-devel@gnu.org; Tue, 10 Sep 2024 23:01:49 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8A42A872C6; Wed, 11 Sep 2024 03:01:44 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a314.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3C26C874D3; Wed, 11 Sep 2024 03:01:44 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1726023704; a=rsa-sha256; cv=none; b=xH05v9nKeuWGgH1cquUN7344UXtHqqn+GLUDI7lLPl8fYQaLxVrXxKvZSnHN/aorGo0eJS 165PK7NR6JEs2YUalzPz+Ndf/Aq0I7CNGAD01hZ/oXLsU7ZyCNr+/xX9qmE7kLZldMs89B 3c0vpRIHKTEMTJ0DRYhOutgpERxuO7NcKdnvltN4UyXvXFLGmLef/2NVb3lo4vliqf0Mdl gx+2DwGf2U8FJTfkWiJeOv4JrMlmGjbwqBJZm77whNWHAJlV5cat0j5nBozyRoKw7C/NTQ hnmOfw5Tbn8MBnKc1R4//W/cZR3A16qCY1SmKHgujVI63nlwZdk8gYU1wGxd8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1726023704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UjADVoLWNr7T/fiVAT5X3RZ+mohkZGf8rubGFcuygnM=; b=KGry20y8wfTajRhxhYmmjQyuT6Icvrv9KkrbPtoLsQUkm/6XdfQRmIbs2bM/Whw66oVWSg VQ6OMPqED/nOVEaWhWMNxdIHyKWNSE4LZmn0eWXqDONrSaRzlajzTp6H5UMrS3Y1hc5F6z MsqB1z/bAYk7Q5i1WvfKWXc4N7c5mOsZfOSxWRoLdwRLWNQb9bMgxMEzIzB9hgsNhHU5xx MnRnWYfohAx7QWiCmNvAIiZijqJJh3A9cdyhQIlMSrCTw7OUexAQHfCP/VQTL9KSwPeSFy 7yob9k3om9katczUefNJihOZE451mOA81trYrWc1LzLgjhMDdSJQApBjEbzvOQ== ARC-Authentication-Results: i=1; rspamd-85dcd79db4-r76qx; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Bored-Exultant: 3a42f6ae73df238d_1726023704450_311638924 X-MC-Loop-Signature: 1726023704450:2788048589 X-MC-Ingress-Time: 1726023704450 Original-Received: from pdx1-sub0-mail-a314.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.118.35.140 (trex/7.0.2); Wed, 11 Sep 2024 03:01:44 +0000 Original-Received: from [10.43.76.65] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a314.dreamhost.com (Postfix) with ESMTPSA id 4X3QMW5j6sz4S; Tue, 10 Sep 2024 20:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1726023704; bh=UjADVoLWNr7T/fiVAT5X3RZ+mohkZGf8rubGFcuygnM=; h=Date:To:Cc:Subject:From:Content-Type:Content-Transfer-Encoding; b=LdAX1PcG5Zf2rstGK+BZBuv4xAeE01Y11sxJ71IlYUjrx0Atj96CsCrKLpCeNDjz+ 4yJOgbhjfIHZy1EdBHbAjJPvf9KNHcVa2x32bIraxyYsOiJAY4PiL56BGCTECDJ2DD 5Fjoe2SnEnPy5RzuBdedDrIX73a/q8VY7J+5+VZJwGi4JA3x19y4814JqQZYayWF5+ /wvDm5x3yh/4Rlm+KeNU1EZevGeW8oKxmj6UFjJAZhAAy03TrVExLcOipbmqbxlUvb dZYDMwOm1eGroEIlCGLkbMbLszQsoZUNgAAg2EaijIVwY2VyTpXnO3FCsMilio6KcA RQP6p81FRyXAQ== Content-Language: en-US In-Reply-To: Received-SPF: neutral client-ip=23.83.218.247; envelope-from=adam@alphapapa.net; helo=weasel.tulip.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323536 Archived-At: Hi Phil, A quick, initial suggestion: it would be good to reformat the Lisp code in both projects, as I see several cases of incorrect indentation, hanging parens, extra blank lines, etc, and some of them would make the code hard to read. For my Lisp editing, I use aggressive-indent-mode, which ensures that the code is always indented correctly. For some other reformatting, Oleh Krehel's Lispy package has commands to help. Also, for org-sql-session (which sounds very useful), it would be good to compare and contrast it with the package it's meant to supersede. And since it's meant to integrate with org-babel, it might be good to discuss its inclusion on the Org mailing list also. --Adam