unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: pe@7d.nz
Cc: emacs-devel@gnu.org
Subject: Re: packages submissions : org-sql-session and org-blog
Date: Tue, 10 Sep 2024 22:01:42 -0500	[thread overview]
Message-ID: <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net> (raw)
In-Reply-To: <b1ca8e9e-be59-4740-8ea8-c3ebd4ba56fe@7d.nz>

Hi Phil,

A quick, initial suggestion: it would be good to reformat the Lisp code 
in both projects, as I see several cases of incorrect indentation, 
hanging parens, extra blank lines, etc, and some of them would make the 
code hard to read.  For my Lisp editing, I use aggressive-indent-mode, 
which ensures that the code is always indented correctly.  For some 
other reformatting, Oleh Krehel's Lispy package has commands to help.

Also, for org-sql-session (which sounds very useful), it would be good 
to compare and contrast it with the package it's meant to supersede. 
And since it's meant to integrate with org-babel, it might be good to 
discuss its inclusion on the Org mailing list also.

--Adam



  reply	other threads:[~2024-09-11  3:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 14:50 packages submissions : org-sql-session and org-blog Phil Estival
2024-09-11  3:01 ` Adam Porter [this message]
2024-09-17 10:00   ` packages submissions : ob-sql-session " Phil Estival
2024-09-17 22:25     ` Adam Porter
2024-09-18  1:41       ` package submission : ob-sql-session Phil Estival
2024-10-20 12:34         ` Ihor Radchenko
2024-11-04 18:16           ` Phil Estival
2024-11-09 14:43             ` Ihor Radchenko
2024-09-11  7:24 ` packages submissions : org-sql-session and org-blog Philip Kaludercic
2024-09-17 10:02   ` packages submissions : ob-sql-session " Phil Estival
2024-09-19  7:47     ` Philip Kaludercic
2024-09-22  4:09       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    --cc=pe@7d.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).