From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages Date: Tue, 12 May 2020 01:21:43 +0300 Message-ID: References: <20200511214134.32634.30981@vcs0.savannah.gnu.org> <20200511214135.F14AF20A23@vcs0.savannah.gnu.org> <54168518-e95e-4eaa-0227-b51466d86cb2@yandex.ru> <87ftc6f7ex.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58383"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 00:22:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYGoW-000F5X-3V for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 00:22:20 +0200 Original-Received: from localhost ([::1]:46048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYGoV-0000Lg-3U for ged-emacs-devel@m.gmane-mx.org; Mon, 11 May 2020 18:22:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYGo0-00087S-BE for emacs-devel@gnu.org; Mon, 11 May 2020 18:21:48 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:36099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYGnz-0006aJ-A4 for emacs-devel@gnu.org; Mon, 11 May 2020 18:21:48 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id w19so6384550wmc.1 for ; Mon, 11 May 2020 15:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GvoNGT94/YZUbUGeEKNetvp8n+Nggye3RaRe6/9eceI=; b=Q6UoXs8g4nbak9X5r7SUq0vWmNL3ZeR9BkVGTPg9nWKrSL+/sTGsDfX6S+rTaE8rfG VybiZPjTi4cY1OvimEtnP9csk9lt3nZjFXZ7MuqaSuS+GJZ4cgnBRotEKakqI3iCwhpA QI/Bxc5i2U7XfcvVixiP5hHuanTIKG9gwIROQEN44d/wRtp8aqRo6vWq3VyDEm1yl4gy f9eg9WtS792ubxsMGxD3TrQYuu6U6CfOeza1/UlyifJYD96YfW1TaazsVf1EzgABUS+9 EgAixiFUaqAX4Llr/fn2wjSOzuXtCsSwYPn1v3up3bcIK3ktm50dEwPNKRhtf4gcCV1Q c5Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GvoNGT94/YZUbUGeEKNetvp8n+Nggye3RaRe6/9eceI=; b=im7ggPrFn9IwbvCYhQV0PgIa+A7HyuiLk3ds0tt8uROfpZggCWc12YqNv4fvA2KbQi k19/tAxGlf0RO7xGUXbst/ar/lJ4zorr9pSOcdgTYFbuM3bREXJgVJY3i6v+DzqmQ/LQ ZKL9+UmkLovbV161dN5mxov5HFCLEYc/z3OFPEpP+EEYjArIYdszCgZqqZ1qFwSALiEV u4ZORMfkOrATL42kALuSUvXT7bTIkcavWoCgX8pBGKJTuQ8Ltq/NdJYIB6wuYuds2wjR N+Tu6mL9YGOYQqbvEPtqKSMg9/ktlbCpussVIfhXs3mBGRhZWff3tNXpUVNqPpsZ/79v qMNQ== X-Gm-Message-State: AGi0PuYCADH8O9ixsKTDHYN5RjQWMzF3S3/PkYzR7SU1gpc4W0fRRpdB ti6u7XH7SC6oly90XCqChOIe0TMz X-Google-Smtp-Source: APiQypJ1g5+Yo6idhmdDmDTJ97TAPgiS1fQVWHKTxMU/RFM5nfsBwNmFXEnifMLZKY3cbCZaeWy2uQ== X-Received: by 2002:a7b:c5d4:: with SMTP id n20mr35259116wmk.92.1589235705418; Mon, 11 May 2020 15:21:45 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id g184sm14159868wmg.1.2020.05.11.15.21.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 15:21:44 -0700 (PDT) In-Reply-To: <87ftc6f7ex.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=raaahh@gmail.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249899 Archived-At: On 12.05.2020 01:12, João Távora wrote: > Dmitry Gutov writes: > >> On 12.05.2020 00:41, Jo�o T�vora wrote: >>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >>> index f5f4092..6be1500 100644 >>> --- a/lisp/progmodes/project.el >>> +++ b/lisp/progmodes/project.el >>> @@ -1,6 +1,11 @@ >>> ;;; project.el --- Operations on the current project -*- lexical-binding: t; -*- >>> ;; Copyright (C) 2015-2020 Free Software Foundation, Inc. >>> +;; Version: 1.0.0 >> >> Please make this one "0.1". > > No problem, I guess, but sure you don't want "Semantic Versioning" > stuff? I think we should indicate its current pre-release status somehow. > Also, why only that one ? Any reason why I shouldn't _also_ use > 0.1 for eldoc.el and xref.el? They seem more stable. > Regardless, I have two serious-ish problems here: > > 1. xref and project.el have a cyclic dependency. xref.el depends > (properly) on project.el but it seems project.el also depends on > xref.el. > > > (defun project--files-in-directory (dir ignores &optional files) > (require 'find-dired) > (require 'xref) > (defvar find-name-arg) > > > How should I fix this? Any ideas? Or should I be creative? Are cyclic dependencies a problem for package.el? I'm not sure. > 2. It'd be nice if both xref.el and project.el were available for Emacs > 26.3. But project.el in Emacs master depends on fileloop.el, which > in turn depends on generator.el. OK? Should I make both fileloop.el > and generator.el :core packages, too? fileloop is new, but generator.el has been there since Emacs 25, IIUC. fileloop could also be an optional dependency, considering it's only required by a couple of commands.