From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4b79c80c999 1/2: New function 'sort-on' Date: Mon, 5 Feb 2024 02:48:33 +0200 Message-ID: References: <170688047526.14693.2994051491358257471@vcs2.savannah.gnu.org> <20240202132756.4272CC0EFE7@vcs2.savannah.gnu.org> <87cytej4hy.fsf@daniel-mendler.de> <86zfwi52m1.fsf@gnu.org> <87plxe28as.fsf@web.de> <86wmrm50i5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25362"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eli Zaretskii , Michael Heerdegen , John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 05 01:49:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rWnAr-0006LI-Vw for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Feb 2024 01:49:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWnAD-00043L-0Z; Sun, 04 Feb 2024 19:48:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWnA9-00042v-LO for emacs-devel@gnu.org; Sun, 04 Feb 2024 19:48:42 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWnA7-0000gh-Il; Sun, 04 Feb 2024 19:48:41 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 009653200A16; Sun, 4 Feb 2024 19:48:36 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 04 Feb 2024 19:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707094116; x=1707180516; bh=kuPIJGOpP5CIJm9c+faWAl2Lnr71bFptttscr/2CoBQ=; b= ozLdkUm8znxyloazdIF26UfwFl73Dn2AIuFPvin6yJcpPMrKeo/vQ+xVfI01DUI1 C0L0PT8HydU/JuVFW5U4JwImNrjoD+gh+NQdocHYgAARZWX20LmEuiPvOegeCbvu ho60003FIlZPr8wT/1JoRuJdOHrs9x5Epus4H99XFedGzg+7tyEsTOhpWW369STr TtUYSX4jT8bQdpwI0lkd/M60SevhK94PC8bruajY3497ZlWWj5cUBZHAg1vdqOoC Jaj7LlZkGmE24GfUSpRzO+Lhh0FC0OuiTqOYl6hcs+FFOmQiXM+TUIgHnrmGJPfa XdEGVcZcgnz/hxERt4dqjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707094116; x= 1707180516; bh=kuPIJGOpP5CIJm9c+faWAl2Lnr71bFptttscr/2CoBQ=; b=I YKwyMem3vsHDEIC6RVbSRxTYYagW+L/Rl++KyIB0b+pzzUCImtyPoZ72HqGOIdbd SDGGyds6ZE88MOlGLf4XGo4ePlxIKhSZKpjQ1UrwQBKC9Z5tl2NxFV15s1JKyqmN +WQfR1gAanymCVGJB7yavvplGW2lHGWbZYKn1l0E49GEbNQdZNinXFqFkWFP5NxU bvm4yHtS/rjNnu31YoBEfga3Qvwl+MDIEdndcWesV/dXH3dCp09Gol7VnI0Gpacq 4BXCmh+fUiPFRZp5WiR3mp+VbEVX64dWTJZ0sxXkztM4026ruav3XbYYxunMMZkC wySKWB6FfmqZg00duWNCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfeduledgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefhteeufeegudeltdekgedufeduteevtefggfejhfekgeegfeehgeejgeet jeefnecuffhomhgrihhnpegvlhdrihhnnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Feb 2024 19:48:35 -0500 (EST) Content-Language: en-US In-Reply-To: <86wmrm50i5.fsf@gnu.org> Received-SPF: pass client-ip=64.147.123.20; envelope-from=dmitry@gutov.dev; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315873 Archived-At: On 02/02/2024 17:50, Eli Zaretskii wrote: >> Date: Fri, 02 Feb 2024 16:30:03 +0100 >> From: Michael Heerdegen via "Emacs development discussions." >> >> Eli Zaretskii writes: >> >>> This function can only sort lists, so at least from that aspect its >>> place is not in seq.el. In addition, I see no reason to have it >>> preloaded. >>> >>> I've put it in sort.el because the function 'sort' is there. >> Both places make no sense to me. > I'm sorry that it doesn't. It does to me, so let's agree to disagree. Why don't we resolve this disagreement by turning the newly added function (sort-on) into a new optional argument to 'sort' instead? The result would make it destructive and consequently faster (not entirely non-consing, but close to it--while the current sort-on creates two extra lists of length N), which should fit the original goal: a faster sorting routine then uses ACCESSOR.