From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: SIGIO and the NS port Date: Sun, 21 May 2017 00:46:53 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20170310124117.GA74077@breton.holly.idiocy.org> <20170313163817.GA40836@breton.holly.idiocy.org> <20170520232406.GA21521@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1495352866 6189 195.159.176.226 (21 May 2017 07:47:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 May 2017 07:47:46 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 To: Alan Third , Emacs-Devel devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 21 09:47:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCLaT-0001Kn-Aq for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 09:47:37 +0200 Original-Received: from localhost ([::1]:36687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCLaX-0001jQ-2G for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 03:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCLZr-0001j9-Jq for emacs-devel@gnu.org; Sun, 21 May 2017 03:47:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCLZo-0002Ag-IS for emacs-devel@gnu.org; Sun, 21 May 2017 03:46:59 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dCLZo-0002AL-CE for emacs-devel@gnu.org; Sun, 21 May 2017 03:46:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DB0CA160051; Sun, 21 May 2017 00:46:54 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rJxr2nOvTvum; Sun, 21 May 2017 00:46:54 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 25C3516007F; Sun, 21 May 2017 00:46:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kCvB2vJDBtKR; Sun, 21 May 2017 00:46:54 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 011E5160051; Sun, 21 May 2017 00:46:53 -0700 (PDT) In-Reply-To: <20170520232406.GA21521@breton.holly.idiocy.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215038 Archived-At: Alan Third wrote: > I=E2=80=99ve stopped the signal handler from responding to SIGIO, I'm not following, as sigaction (SIGIO, ...) is still being called, so th= e=20 signal handler deliver_input_available_signal is still responding to SIGI= O, and=20 is setting pending_signals to true. The changes you made affect SIGUSR1 and SIGUSR2 handling, since they patc= h=20 handle_user_signal: they cause the SIGUSR1 and SIGUSR2 handler to not pro= cess=20 SIGIO events. Also, they prevent SIGIO from being masked out during non-S= IGIO=20 signal handlers. Is that what you intended? I'm not getting the connectio= n=20 between these non-SIGIO handlers and interrupt_input. > and the two > places where the NS GUI used to raise SIGIO have been replaced with > direct calls to the SIGIO handler code. That sounds like a reasonable thing to do in any event. I don't see why t= he code=20 needs to do a raise (SIGIO) when it can do a handle_input_available_signa= l (SIGIO);