From: dqs7cp2e <dqs7cp2e@gmail.com>
To: emacs-devel@gnu.org
Subject: Suggestion for package.el: atomic package-upgrade
Date: Mon, 31 Jul 2023 08:58:16 +0700 [thread overview]
Message-ID: <d81cccec-835d-b922-def9-5a603258387c@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
The current `package-upgrade' from package.el delete old package
before installing the new one. This can be problematic if the user
interrupt the process or if there is some network problems.
`package-install' allow the same package to be installed if the
argument is `package-desc' instead symbol representing package name.
This allow package to be upgraded atomically. Is this a bad idea?
[-- Attachment #2: package-upgrade--diff.txt --]
[-- Type: text/plain, Size: 1691 bytes --]
diff -u --label \#\<buffer\ package.el.gz\> --label \#\<buffer\ \*scratch\*\> /tmp/buffer-content-4azQGZ /tmp/buffer-content-x8FLpt
--- #<buffer package.el.gz>
+++ #<buffer *scratch*>
@@ -2275,16 +2275,20 @@
package using this command, first upgrade the package to a
newer version from ELPA by using `\\<package-menu-mode-map>\\[package-menu-mark-install]' after `\\[list-packages]'."
(interactive
- (list (completing-read
- "Upgrade package: " (package--upgradeable-packages) nil t)))
- (let* ((package (if (symbolp name)
- name
- (intern name)))
- (pkg-desc (cadr (assq package package-alist))))
- (if (package-vc-p pkg-desc)
- (package-vc-upgrade pkg-desc)
- (package-delete pkg-desc 'force 'dont-unselect)
- (package-install package 'dont-select))))
+ (list (intern (completing-read
+ "Upgrade package: " (package--upgradeable-packages) nil t))))
+ (let* ((name (if (symbolp name)
+ name
+ (intern name)))
+ (old-pkg-desc (cadr (assq name package-alist)))
+ (new-pkg-desc (cadr (assq name package-archive-contents))))
+ (if (package-vc-p old-pkg-desc)
+ (package-vc-upgrade old-pkg-desc)
+ (unwind-protect
+ (package-install new-pkg-desc 'dont-select)
+ (if (package-installed-p (package-desc-name new-pkg-desc)
+ (package-desc-version new-pkg-desc))
+ (package-delete old-pkg-desc 'force 'dont-unselect))))))
(defun package--upgradeable-packages ()
;; Initialize the package system to get the list of package
Diff finished. Mon Jul 31 08:22:46 2023
next reply other threads:[~2023-07-31 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 1:58 dqs7cp2e [this message]
2023-07-31 6:45 ` Suggestion for package.el: atomic package-upgrade Philip Kaludercic
2023-07-31 13:13 ` Tegar Syahputra
2023-08-01 7:32 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81cccec-835d-b922-def9-5a603258387c@gmail.com \
--to=dqs7cp2e@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).