From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Thu, 02 Jan 2025 22:19:06 +0300 Message-ID: References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <083310b3-a288-5c75-c835-84595e134682@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.54.2 To: Jim Porter , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 02 20:19:55 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTQja-0004Rr-3x for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jan 2025 20:19:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTQj5-0003cB-0U; Thu, 02 Jan 2025 14:19:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTQiz-0003bV-8t for emacs-devel@gnu.org; Thu, 02 Jan 2025 14:19:17 -0500 Original-Received: from forward501d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d501]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTQiw-0007Fb-52 for emacs-devel@gnu.org; Thu, 02 Jan 2025 14:19:16 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-47.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-47.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:8f4f:0:640:c72e:0]) by forward501d.mail.yandex.net (Yandex) with ESMTPS id C17C960C08; Thu, 2 Jan 2025 22:19:07 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-47.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6JmuGsdOnmI0-ZFx5dN8u; Thu, 02 Jan 2025 22:19:07 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1735845547; bh=lWXIHEUGMXUec9Ta8/fQh/LAdMq+Elhyo1n/0rzRQ2A=; h=In-Reply-To:Date:References:To:From:Subject:Message-ID; b=F9eUrgmkYsZ+RECaUSYKRPbLYymW6SHxqY0OWV1Yy7k5yXsVnALh3qVgg/wbHT0BR lLvs7uMJhtFNZosUwwjjo3QoGdr1ELs4WDAVGYOJihXyetIN/kcP5S5vrKcj99b0tz PJ3GNKUWzpsZGL7Zdf9fWNEuj2gkbvXIp5OmwvRg= Authentication-Results: mail-nwsmtp-smtp-production-main-47.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <083310b3-a288-5c75-c835-84595e134682@gmail.com> Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:d501; envelope-from=Hi-Angel@yandex.ru; helo=forward501d.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327586 Archived-At: On Thu, 2025-01-02 at 11:17 -0800, Jim Porter wrote: > On 1/2/2025 10:30 AM, Konstantin Kharlamov wrote: > > But Emacs seems to be the only widely popular editor that still > > doesn't > > provide OOTB at least syntax highlight for git-commit format. So, > > does > > anyone have opposition to adding a major mode that would be bound > > to > > filenames like `COMMIT_EDITMSG` and others, and would provide the > > aforementioned highlight? >=20 > For what it's worth, I wrote a very simple package to do this for=20 > myself, since I don't use Magit. (I'm just so used to the Git command > line that I've never taken the time to mess with Magit.) >=20 > https://github.com/jimporter/git-command-modes/ >=20 > I'm happy to assign copyright to the FSF for this or to upstream this > into the Emacs tree, or whatever people would like here. Sounds great, I see you even got tests there! And you're the only contributor, so yeah, I presume it would work just fine.