From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4a1e97b: New user option for Git log switches Date: Wed, 9 Jun 2021 19:01:44 +0300 Message-ID: References: <20210608233619.8439.15341@vcs0.savannah.gnu.org> <20210608233620.E895F209C6@vcs0.savannah.gnu.org> <875yyn2st3.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14014"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Utkarsh Singh To: Michael Albinus , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 09 18:17:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lr0tg-0003V3-Hf for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Jun 2021 18:17:40 +0200 Original-Received: from localhost ([::1]:46310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr0tf-0001a4-KN for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Jun 2021 12:17:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr0eN-00010v-48 for emacs-devel@gnu.org; Wed, 09 Jun 2021 12:01:51 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:33464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lr0eL-0000wM-5P for emacs-devel@gnu.org; Wed, 09 Jun 2021 12:01:50 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id a20so26154636wrc.0 for ; Wed, 09 Jun 2021 09:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i8FFbFatXgUU19YvKizM3MZug1+3eNLRu1u0XEHDRn0=; b=gQowEqPzaigJBDtPecNRcTuJZ/WeheIDNrThDCx/PhfjXChdC5Ck3pM10ur0FSe9Lq tbzehz9goo6+e+Sd+1lqf89sIvF8dCZjiNqxCDOlVGD8PWSFGigUzzZFdr/7Bb2pMwsQ Qw+iE+V0JGhjZe6PerTiLzf591k5cemkurFrCGjxFiFjC4Os+u8T+RHnOhIC8k5w6H0T orEuqemuyKzAfAwYiLbMibBLvO287belDG4NsFQ4f9+zVEEcbmiwLrr2Kk0e/aJa4bzg Zn3R+b20yaT7775c2aJQWhzsTc//WGbzFjJWRgDNQ1XBhe53QpVO0kB74c7KPBTt/+AQ RdpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i8FFbFatXgUU19YvKizM3MZug1+3eNLRu1u0XEHDRn0=; b=VTI8jO6EcVgj1U7dDYSTd6e7yPvXjSjToUjqz7KbAOUYNG7i7/XtLxUbPQFDB+rzIr vxNIGf4+0WBk3XcgOdW4z2V7EB13oMjXkVV9xAIc3mmc7aI/nZjCG02Cj17oLjiIklNC /2gLJblSjvHgZaVmHCbwRl3qtBXqs+ZFbWSid+T48K68UDZYJAjLamz40IKHBg4PkM6N uEq/VBoffe1WREIp/8sywVk7oUlG6DJr5ondAlaoqFtBwJhbGgWKx6MZ1HK3m1LtgS2Q 8K456FpTeigrFGwdOVV4oG4t2wHFYWBb8tVlnzOXcQ0+zgLX7r6/pppUn1WBav0BTmDr KYYw== X-Gm-Message-State: AOAM533QdKZekprJIkoNSRsZLUVHcsLUnMwT9PMSsdV/yRiVuMAYbZ/b zPWXm5G8vrSzDjjp84acEwo= X-Google-Smtp-Source: ABdhPJywR8rwjqAmYqxkydORUMZWkFzIfWAVoYXFW2BPrOl8WoMAThikZ0MXuC4KyPjwRBtnxJ8uQw== X-Received: by 2002:adf:f1c3:: with SMTP id z3mr502450wro.375.1623254506503; Wed, 09 Jun 2021 09:01:46 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p12sm6098353wme.43.2021.06.09.09.01.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 09:01:45 -0700 (PDT) In-Reply-To: <875yyn2st3.fsf@gmx.de> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=raaahh@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270600 Archived-At: Hi Michael, On 09.06.2021 14:14, Michael Albinus wrote: >> +(defcustom vc-git-log-switches t >> + "String or list of strings specifying switches for Git log under VC." >> + :type '(choice (const :tag "None" t) >> + (string :tag "Argument String") >> + (repeat :tag "Argument List" :value ("") string)) >> + :version "28.1") > > Is there a reason to use the t value for "None"? All other log switches > (vc-bzr-log-switches, vc-hg-log-switches, vc-src-log-switches) use nil > for this purpose, and it sounds also more natural to me as being an > empty list of strings. nil also works. The author followed the example of 'diff switches', where there is a certain hierarchy of variables to follow if the backend-specific one returns nil. I figured it wouldn't be too bad to allow that possibility in the future, but you are probably right and we should simplify this. 'hg log' and 'git log' are pretty different after all.