From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Cc: Utkarsh Singh <utkarsh190601@gmail.com>
Subject: Re: master 4a1e97b: New user option for Git log switches
Date: Wed, 9 Jun 2021 19:01:44 +0300 [thread overview]
Message-ID: <d5a84eab-ce8a-47f0-83c9-edaeeb2bf932@yandex.ru> (raw)
In-Reply-To: <875yyn2st3.fsf@gmx.de>
Hi Michael,
On 09.06.2021 14:14, Michael Albinus wrote:
>> +(defcustom vc-git-log-switches t
>> + "String or list of strings specifying switches for Git log under VC."
>> + :type '(choice (const :tag "None" t)
>> + (string :tag "Argument String")
>> + (repeat :tag "Argument List" :value ("") string))
>> + :version "28.1")
>
> Is there a reason to use the t value for "None"? All other log switches
> (vc-bzr-log-switches, vc-hg-log-switches, vc-src-log-switches) use nil
> for this purpose, and it sounds also more natural to me as being an
> empty list of strings.
nil also works.
The author followed the example of 'diff switches', where there is a
certain hierarchy of variables to follow if the backend-specific one
returns nil.
I figured it wouldn't be too bad to allow that possibility in the
future, but you are probably right and we should simplify this.
'hg log' and 'git log' are pretty different after all.
next prev parent reply other threads:[~2021-06-09 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210608233619.8439.15341@vcs0.savannah.gnu.org>
[not found] ` <20210608233620.E895F209C6@vcs0.savannah.gnu.org>
2021-06-09 11:14 ` master 4a1e97b: New user option for Git log switches Michael Albinus
2021-06-09 16:01 ` Dmitry Gutov [this message]
2021-06-10 7:34 ` Michael Albinus
2021-06-10 14:56 ` Utkarsh Singh
2021-06-11 1:41 ` Dmitry Gutov
2021-06-11 1:40 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5a84eab-ce8a-47f0-83c9-edaeeb2bf932@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=utkarsh190601@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).