From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jari.aalto@cante.net (Jari Aalto+mail.emacs) Newsgroups: gmane.emacs.devel Subject: Re: RFC: comint.el - comint-highlight-prompt and unreadable colors Date: Mon, 26 Mar 2007 16:51:10 +0200 Organization: Private Message-ID: References: <87y7llxxdu.fsf@catnip.gol.com> <87slbsyjn7.fsf@catnip.gol.com> <87wt14a158.fsf@pacem.orebokech.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174920766 10858 80.91.229.12 (26 Mar 2007 14:52:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 26 Mar 2007 14:52:46 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 26 16:52:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HVqYp-0007sZ-0i for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2007 16:52:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVqb4-0004MZ-A0 for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2007 09:54:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HVqa4-0002PH-D2 for emacs-devel@gnu.org; Mon, 26 Mar 2007 10:53:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HVqa0-0002Co-AY for emacs-devel@gnu.org; Mon, 26 Mar 2007 10:53:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVqa0-0002CS-6m for emacs-devel@gnu.org; Mon, 26 Mar 2007 09:53:52 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HVqXj-0006st-R9 for emacs-devel@gnu.org; Mon, 26 Mar 2007 10:51:32 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HVqXf-0005vW-1z for emacs-devel@gnu.org; Mon, 26 Mar 2007 16:51:27 +0200 Original-Received: from a81-197-175-198.elisa-laajakaista.fi ([81.197.175.198]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 26 Mar 2007 16:51:27 +0200 Original-Received: from jari.aalto by a81-197-175-198.elisa-laajakaista.fi with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 26 Mar 2007 16:51:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: a81-197-175-198.elisa-laajakaista.fi User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (windows-nt) Cancel-Lock: sha1:in3boG/20c1b7l9e5dyI4XE19jI= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68610 Archived-At: * Mon 2007-03-26 Miles Bader gmane.emacs.devel > > Basically, unless you have a proper frame-background-mode, then _all_ > the highlighting in Emacs will be fairly screwed up: a large percentage > of the colors used in Emacs highlighting only look good against the > proper background type. Attempting to pick "neutral" faces for > everything simply doesn't work -- it's hard enough making things look > good if you _can_ depend on the background type -- and the problem is > even worse on ttys with their limited selection of color and alternate > font styles (basically only bold, and often not even that, works). > > So even if we changed the comint prompt to make you happy, the entire > rest of the interface will still look awful. However, the problem is not so noticeable elsewhere. > If you can find a way to detect Putty/rxvt then Emacs could use that > information, but absent that, I don't think there's any choice but user > education. > >> Do you have in use cases where 'bold would not work? > > Bold is already used in comint. But for the real problem, see above. Forgive, I wanted to ask if there is any cases where 'bold would pose similar visibility problems. (defface comint-highlight-input '((t (:weight bold))) "Face to use to highlight user input." :group 'comint) (defface comint-highlight-prompt '((((min-colors 88) (background dark)) (:foreground "cyan1")) (((background dark)) (:foreground "cyan")) (t (:foreground "dark blue"))) "Face to use to highlight prompts." :group 'comint) => (defface comint-highlight-input '((t (:weight bold))) "Face to use to highlight user input." :group 'comint) (defface comint-highlight-prompt '((t (:weight bold))) "Face to use to highlight prompts." :group 'comint) Wouldn't this work ecorrectly over variaety of terminals? The comint (M-x shell) is the primary interface to work fluently with the shell, so is it's usability is a high prriority problem. Jari