From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Adding olivetti to GNU ELPA Date: Fri, 10 May 2019 10:00:10 +0200 Message-ID: References: <83tvemzcn2.fsf@gnu.org> <9bb5fc63-61ae-44dc-a8d5-b67803eab1e5@www.fastmail.com> <83h8amz24g.fsf@gnu.org> <24cca761-36ea-4c16-bce1-e3651aad52c8@www.fastmail.com> <83ftq6yx5o.fsf@gnu.org> <83ftppii16.fsf@gnu.org> <875d1b0c-7f44-ba5d-4660-84637533b8f3@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185451"; mail-complaints-to="usenet@blaine.gmane.org" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 10 10:00:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hP0SB-000m4s-OU for ged-emacs-devel@m.gmane.org; Fri, 10 May 2019 10:00:27 +0200 Original-Received: from localhost ([127.0.0.1]:38599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP0SA-0006Qx-O1 for ged-emacs-devel@m.gmane.org; Fri, 10 May 2019 04:00:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP0S5-0006QC-03 for emacs-devel@gnu.org; Fri, 10 May 2019 04:00:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP0S3-0001cZ-1U for emacs-devel@gnu.org; Fri, 10 May 2019 04:00:20 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:48995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hP0Rz-0001Vy-9V for emacs-devel@gnu.org; Fri, 10 May 2019 04:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557475206; bh=x8fx8EKxV3txFQZ26FvIkHLTE0fSFXXt3PLUrZ2ztUU=; h=X-UI-Sender-Class:From:Subject:To:References:Date:In-Reply-To; b=DAz0MeB1T3tAezfnk4N2pvwaOizq3Hgprw90JdJZJeh416+oXr5uMqKeGgtAkvjIh Rz8Aaj+hENkoLwgBbbMtCOg4UEblzOnYrvZSLxbZNabBehuxpKRLP8vO1b/elneAbR JbVDbRKcMPxxy1+BOGnIFnkmpsFRgNpsFNV+DzAs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.202]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtOKi-1ga3Bo08FC-00uu7T; Fri, 10 May 2019 10:00:06 +0200 In-Reply-To: Content-Language: de-DE X-Provags-ID: V03:K1:hZ++we/vwwR/3R4Vvdphm/fYBR3T+nTww2FfjHRDvTGvqlP/tOt NhJ4jroH2FR7Rdg1/qOEP0LJkNc/tMVo2eZLwdWP+rL6Pe5ST+cKCBVWVIdJKz+54TNTmdA RhCoRKxp5smsnRmGcONcH756U1GXH3qy33XDNHtSsilISpQI7g6Yxj1k37O+Za/44KwOqJ3 3cNPvxplsVJeW0R0dI/4w== X-UI-Out-Filterresults: notjunk:1;V03:K0:EgYnIsfqglE=:wUr+jy+9CuloHwO+iuj/vb lUhyC/evxlvX7z3FQv+hAAA/U3BNSXMJM2+B5LdaoQQQR+FUXoTApdZaK1GhslUpzr+MemZw8 D0WbvDO66e5V1E5+qGVcOvRrVZEEb6ADIjC6IThKFKj/IpeQg3yrSCGUHh3erb5zjpwHhc+Dm +GcyEgI+VITN9R8pp/5IJlTP3PYHr8fK8D2NnQtE3P1eLUfE0DWp3in9X22kPT8PtyuYuc/LA 2aQtAfrAZ1gyHHranjsM3pgdhzuR41xa5huJZuvWAEx1xp25kFttg1M7NBKvxX+bJQEaVWSgM jg/Wy2yUT7JaKmNKalNd8g3cKvS/C8QLWG3ZkG/pe92R8lyp9rKUeVokVrqZdkDNnWpUikKLT wNfuBHnvh1xvJDKDd7J7USaQgRAGwSpxk4p7cLHIv5vVZbuGwvKaB3STCS3AUdCm77Vw9zuC3 lFxV1qC8cAP3wOUROQTYXCdxmtbARbjN4tqhR0d1gX73LdMN2Gz8LJPS4BLwaM9Bxz1u8/OxT YMy5XPSciMIVK+xbH46YpsqLjWOQkWXlv5YgKPF5zOB+QZT+Ep/xBKxCvLnZJ2ZjbIPSeYzB/ oFjyu4qOmcCH4a7R3n6IXhpRimrf8iUs9HA14yV84+6qI6AfaS5lvcA1DiwPvUBma/lgAOFdl Z0qM8D1rIpFPTQG2UoanxwLKm2IHogZDhFiBneMk1VtCUTlucUbx9lnVvdM4fuilETmv6hOtA 8bwF3UWF1P5curUlnwfiQLcQGs44chsHPj9uXjccBmSOr5tYbpFWfgHUpIHHxrG+aMF4bPbS X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236357 Archived-At: > I think the issue here is that even when margins "aren't modified", > olivetti does change them, because it first sets them to 0 before > setting them again to the previous value, as can be seen in > olivetti--set-margins (which is function called for post-command-hook, > window-size-change-functions, and friends): > > (defun olivetti--set-margins (&optional window-or-frame) > [...] > (olivetti-reset-window window-or-frame) > [...] > (set-window-margins window-or-frame left-margin right-margin)))) > > (defun olivetti-reset-window (window) > [...] > (set-window-margins window nil)) > > I don't know why it starts by calling olivetti-reset-window. > But I think that for Emacs-27, it doesn't matter because it should only > use window-size-change-functions so the extra (set-window-margins window > nil) shouldn't be problematic. 'window-size-change-functions' gets also called when the total or text height of the window changes. In either of these cases, resetting the margins is gratuitous. martin