From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Potential bug in the logic of rmail-select-summary Date: Wed, 20 Jan 2021 17:51:22 +0100 Message-ID: References: <87zh13wvh3.fsf@gkayaalp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, emacs-devel@gnu.org To: =?UTF-8?Q?G=c3=b6ktu=c4=9f_Kayaalp?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 20 17:54:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2GkS-0000X2-9C for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Jan 2021 17:54:24 +0100 Original-Received: from localhost ([::1]:33378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2GkR-0000xd-9C for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Jan 2021 11:54:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Ghj-0006xX-4P for emacs-devel@gnu.org; Wed, 20 Jan 2021 11:51:35 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:59521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Ghg-0007AJ-Ec; Wed, 20 Jan 2021 11:51:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611161483; bh=cA3/7wkfnCJ3Es+CO0Xlz0ddLMBKHS9ZF4psyFdce/4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=X0C8bNLRaT3eQxRz+NGSer1F+OigtlJLYwOWq3JXMMdjhaHrOlWz3gVXxuTh6JtXg n2N8TgCu3Ey8bIcHVMln+feKMgGmqZK7WB5DxC9pozHpvWfbx8S8u3ZrasMrpZAbkl DYZcPkw7ja/YrInJvnuD0gqeT2ysqp2bI8ciqp/s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.241]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFKGP-1lDYBO0kxt-00Fh51; Wed, 20 Jan 2021 17:51:23 +0100 In-Reply-To: <87zh13wvh3.fsf@gkayaalp.com> Content-Language: en-US X-Provags-ID: V03:K1:bhBCZ3mKIbODFll3GsPY8uS1Jc+Zow2YuvXDzz7nZJue15VVPP+ Svaj8PxP28jQeFOcZSj2ikIl0c5QgfUzjtTRqGWG78uChDK2Rgx2RPC3ifHiIdRLehOGiVu yPVTN/2ITAM8DbmdC+6O2fYjN/EjeziqGiac+lb2zCq4WJ8vjZROGxrFx4wcJO1/rBX0yYZ UR+PlyLoIXXlztGgB2H8Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:0V67pPV37fk=:MW0rHGnTANYPfe36dITOhM SvDjnHV3ZYSN4BZ5aVX2NMZMchXCJ2G/1TgNCKEoEYBb9XwjPtV7boK7YFqXTabba0ZrwVLp7 PvXZWar6tidScyXZxDB2joxyDwdjgtCGKIF+632JnJ5tEOFzxCZDV8YT7Q5jK8WmYnCklcnib MSXwcz5DBk/b1BKgjz21wW+8BxkBHBaxbk9fC+jHci0Yis29Hp2lOBIRso4tZfNTdv6X7YXQL vPTriTG6Ys7nBLhrT+IeIIpsOVBBqbp2k3RodB4k6R/RAGBQxmyq/7JJnLG77QhbA1ffFXaV0 DZyr6tD++h3hBbdQ8sRmoMJvnX7A179ay+tx/TC4LRaj8HztKk/a9dmdxcbQDSVuEEaC0JpDT Uhc5Q4jiFMSOIGTZJPasY6FYWEBnMBce9dlcXe/tU8OFsEGoAgGa46Nz1Sgg0j/1K6oX71I/W 1+cZJq4qpwL4tsvXFj2d7RvHtqu7OwxWW+p2N/ZG2Q7Ya5EIPbyd75zmVYYYkA+Rt5bsbILJw aNuIbTRvZt8MuBgyNqhwaXa2dIl0RpvhJYBE/eBxBBb1r8Ro+uMG+s0ugga0og0gTdtTB/jUO ZD2FCTw2Ltdd0167MSDd/RRjKr51o4OWt/fjsjZO+/aGRbxSqEloBmX7Yhhov12HeQxY4QGbd zySwj0colmmVhUuWuTVsVZr9/kIep6nc5FuK8VnHVfQnBvrGmaAVwTZa1rUbz6w50ZgciblgI MYZ8vjT1ClgrfW7FzimiLYhOnYxQrO2foQCQU1BGfNEx+wzlY5wUNEQyOp0js2fKFK/X75b8 Received-SPF: pass client-ip=212.227.17.21; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263213 Archived-At: > A > more sophisticated config which is what I=E2=80=99d actually like to h= ave > behaves a bit more weirdly: > > (setq > display-buffer-alist > '(((lambda (b _) (eq (with-current-buffer b major-mode) 'rmail-summa= ry-mode)) > . > (gk-display-buffer-for-rmail)))) > > (defun gk-display-buffer-for-rmail (buffer _) > (if (=3D (length (window-list)) 1) > (display-buffer-in-direction buffer '((direction . left))) > ;; If there are 1+ windows, use the top quarter of selected > ;; window. > (split-window-vertically (/ (window-height) 4)) > (switch-to-buffer buffer))) While the 'switch-to-buffer' is not entirely kosher in this context ('display-buffer-in-direction' returns a window, 'switch-to-buffer' a buffer) this function should do what you want when applied to some arbitrary buffer. However, it misses one important aspect of the original 'pop-to-buffer': When a non-selected window showing the buffer already exists, it reuses that window. Your function doesn't do that and that causes the problems you see when it is called multiple times in a row (as rmailsum.el does) because it always tries to make a new window. So I suggest you put a 'display-buffer-reuse-window' at the beginning of 'gk-display-buffer-for-rmail' and test how it behaves then. martin