From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 19:21:12 +0300 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <7b11b61f-c70d-7079-9bb2-7069a6e0170b@yandex.ru> <86ler4laek.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 18:39:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTQjz-0004Op-FC for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 18:38:59 +0200 Original-Received: from localhost ([::1]:39286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTQjy-0003c5-1o for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 12:38:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTQTV-0002Pr-1b for emacs-devel@gnu.org; Wed, 31 Aug 2022 12:21:59 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:38754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTQTQ-0000Uq-Ci; Wed, 31 Aug 2022 12:21:56 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id b5so18947786wrr.5; Wed, 31 Aug 2022 09:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=sC9JMGVUxhHSWgif5UYFwnTeYpO0UfjCwow4rzSnhdo=; b=Njot50AVddSEho283qbOkkF9z2JQLQyuoBxlk+Vr96bagWbbAWz85khp3ahTNYiAZF bRA+/SZIS76a6rpmTNAjbzOR5OjP1XPVofxf0m+UxJgWaiR2PSPkykSMS5AsvSlJP9xL w9xN3Kt9D08qze1i3uwo1b6Eb9HsDOB/Y7Szkui6tjsvFVluwz5fVFDGQknJvvA3etkT Fr0nrigXcOGeD+1GnNfso/M6G/d95Yns9FsTNf3HDJ9j/sr6o73THootftma3Y9B9sO4 M3CyG5zC34e5Rmk4W8v5BIwwmPQ7Hjb0BdQfzGIG06LtKY5uHgLa7AJ28fGabdkHtu6L GaqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=sC9JMGVUxhHSWgif5UYFwnTeYpO0UfjCwow4rzSnhdo=; b=3onZtRRKN439bYqCkYhkqjZm1w10FRsTKdFDCMBI8jHo4jIOyE3y7SmnHzyy88uhEP r6E3QTS6sVo4QDyfTTF8ZuAaS3TxMiSpdBglBhhKNETw+vHBCFOPNHoNJe+lx7z3O6FC DtfVUwz28qssCWNyxmjeIcd0XkBtCsWDMmnTqepLAEMR2S8e9EvwzPdRSuY4VFToKRNH rl9V27I0EDkGP4StLntewLWTihsK9swvTgcsqZT49hF703U2GvprJurGjTo5KcwtLVxB xz3Zk4aebQvOsZhqnI3pIP0nXHvugUDXPeTG0KXcYl5TziD43CdHkZeSPtNB6gsubo5w sq4g== X-Gm-Message-State: ACgBeo3dUaBakM5N3yZy8eO9TfDLhukxa7bskKUkUcETSnESsuFAxlRd riILPenANCM8a3tubyQGafk= X-Google-Smtp-Source: AA6agR4UrLXNooMQqHIWgXyvDo+UJNBjf80RixreTNTR/rujo00PlOZtR+Rcvab7POnUzV/XF4/Sqw== X-Received: by 2002:a5d:64c8:0:b0:226:efbc:75fe with SMTP id f8-20020a5d64c8000000b00226efbc75femr1134207wri.161.1661962877321; Wed, 31 Aug 2022 09:21:17 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l14-20020adfe58e000000b0022377df817fsm12371227wrm.58.2022.08.31.09.21.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 09:21:14 -0700 (PDT) Content-Language: en-US In-Reply-To: <86ler4laek.fsf@mail.linkov.net> Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294440 Archived-At: On 31.08.2022 19:06, Juri Linkov wrote: >> But a loop is necessary because the diff can have more than one hunk, isn't >> it? > A loop is necessary indeed. The problem is that I tried it with Bzr, > but it has such a bug that `bzr diff` adds an extra line at the end, > so it's not (eobp) after the last diff hunk. After removing the > final newline in the*vc-diff* buffer the loop can be finished. Hmm, so how do we apply the full diff in a backend-agnostic fashion? Should we delegate to 'patch', then? And require it to be installed.